Timeline for Should curly braces appear on their own line?
Current License: CC BY-SA 2.5
9 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Dec 1, 2017 at 18:08 | comment | added | Craig Tullis |
Fair enough, it's presentation. Presentation is what led to the Apple goto fail bug, incidentally. I will contend that presentation matters.
|
|
| Aug 2, 2016 at 21:19 | comment | added | Andy | @klaar Assuming your VCS has such a thing as post-commit hooks; not all of them do. And post-commit sounds like something done AFTER the commit is now in the VCS, so likely too late to do anything anyway. Then there's other formatting, things like what R# calls line chomping, and now we're talking about a whole lot of formatting done where the developer doesn't have a chance to review it, and which may matter depending on the language. Or I can just dictate everyone use the same settings, and enforce those mandates with things like a shared R# settings file, which can itself be versioned. | |
| Aug 2, 2016 at 7:17 | comment | added | klaar | @Andy: Isn't there the possibility to use hooks that convert those discrepancies regarding whitespace and braces to a uniform standard uppon commit, to circumvent the noise problem you described? Either way, a proper versioning system should transcend petty things like whitespace or other nonsensical things. | |
| Aug 1, 2016 at 22:26 | comment | added | Andy | @klaar Every modern IDE i've used will change tabs to spaces and move braces to their own line or the end of the "opening" line; I'm not sure why you think the source isn't touched in these cases, and that is the reason for my comment. It IS typically changed by the IDEs depending on the developers settings, which means during a commit I'll see lots of changes which are just noise as the braces got moved to thier own line, thus hiding the ACTUAL change someone did. | |
| Aug 1, 2016 at 7:44 | comment | added | klaar | @Andy: That's exactly the point, the IDE will change how they look, but only in the IDE! The actual source will not be touched. For version control, you can add hooks that translate whatever the setting for curly braces was to a common situation, so that everyone checks code out the same way. | |
| Jun 4, 2016 at 1:22 | comment | added | Andy | The issue is that if you let everyone set their own, things get messy very quickly as commits are done. | |
| Nov 9, 2012 at 14:57 | comment | added | Petruza | Totally agree. It's presentation and not data. | |
| Nov 2, 2010 at 20:52 | history | made wiki | Post Made Community Wiki | ||
| Nov 2, 2010 at 12:43 | history | answered | Jonathan | CC BY-SA 2.5 |