2 personal stuff removed // http://meta.stackoverflow.com/questions/2950/should-hi-thanks-taglines-and-salutations-be-removed-from-posts
source | link

Think about it in these terms:

  • If I were to look at it with the purpose of modifying some code, how long will it take me to find where to do so without talking to you first?
  • Is some code repeated? Can you avoid that?
  • What if you need to invoke a method from another class - can you do it easily?
  • Did you write unit tests?
    • Do they pass?
    • If not, try to write some - probably by doing so it will become apparent how you need to refactor your class.

Lots have been written on this topic, but you need to be bitten by this before you can truly understand what are its consequences.

ps: welcome to the trade ;)

Think about it in these terms:

  • If I were to look at it with the purpose of modifying some code, how long will it take me to find where to do so without talking to you first?
  • Is some code repeated? Can you avoid that?
  • What if you need to invoke a method from another class - can you do it easily?
  • Did you write unit tests?
    • Do they pass?
    • If not, try to write some - probably by doing so it will become apparent how you need to refactor your class.

Lots have been written on this topic, but you need to be bitten by this before you can truly understand what are its consequences.

ps: welcome to the trade ;)

Think about it in these terms:

  • If I were to look at it with the purpose of modifying some code, how long will it take me to find where to do so without talking to you first?
  • Is some code repeated? Can you avoid that?
  • What if you need to invoke a method from another class - can you do it easily?
  • Did you write unit tests?
    • Do they pass?
    • If not, try to write some - probably by doing so it will become apparent how you need to refactor your class.

Lots have been written on this topic, but you need to be bitten by this before you can truly understand what are its consequences.

1
source | link

Think about it in these terms:

  • If I were to look at it with the purpose of modifying some code, how long will it take me to find where to do so without talking to you first?
  • Is some code repeated? Can you avoid that?
  • What if you need to invoke a method from another class - can you do it easily?
  • Did you write unit tests?
    • Do they pass?
    • If not, try to write some - probably by doing so it will become apparent how you need to refactor your class.

Lots have been written on this topic, but you need to be bitten by this before you can truly understand what are its consequences.

ps: welcome to the trade ;)