4

Sample situation: A team of Java developers starts an iOS project. Only one developer has Objective-C/iOS knowledge, and in the beginning he will work on this project alone.

How we can perform code reviews in this situation? What are processes, approaches, tools that this developer will use?

Improve this question
6
  • 3
    As a guess, I'd use the same processes & approaches as with any other code, but plan on more time for the review.
    – Dan Pichelman
    Jul 16, 2013 at 18:56
  • What's the actual situation you are facing? It's frowned upon to ask hypothetical questions on SO. Are you actually doing this? Also, please don't be lazy. Punctuate properly.
    – djechlin
    Jul 16, 2013 at 18:57
  • 3
    Easy peasy. Author should sit along with reviewer and explain what's going on there in code, until reviewer says OK I got it. That would probably be the best way of knowledge transfer one can think of
    – gnat
    Jul 16, 2013 at 20:53
  • 4
    If you are not thinking of Code Reviews as a training tool as well as for other functions, you are doing them wrong. This is one of the primary reasons fro CR.
    – mattnz
    Jul 16, 2013 at 22:37
  • @mattnz I disagree with this statement. The reviewer is not always matched or superior in skill and knowledge as the developer. Often times as a reviewer myself, I learned a new way of approaching an old problem. This may not directly help the code, but the team is overall stronger because of it.
    – maple_shaft ♦
    Jul 17, 2013 at 0:08

3 Answers 3

Reset to default
5

The same process would go for any development. I understand and agree it would be, little more work in a new technology, but once you create few test cases, you will be basically eyeing for same errors(Mathematical/Logical/) as in other technologies.

So,

  1. List all the test cases.
  2. Discuss it with your peers. (Team Work is very important here.)
  3. If possible join some groups in apple developers (for Objective C) and look for more information.
  4. Also look for some more information in SE.

This link will help you get more information on the same. Code Review

Improve this answer
0
10

In this situation, code reviews would be a great way to spread Objective-C/iOS knowledge throughout the team, so that someone else can fix bugs when the iOS developer goes on a honeymoon/quits in a huff/gets hit by a bus/is moved to a higher priority project.

Finding bugs is only half the value of code reviews. Spreading knowledge (about both the technology and the solution implemented) is the other half.

Besides, a decent Java developer may well spot logic errors/etc. in Objective-C code. Just the act of saying "So why do you do this here?" can easily cause the original developer to spot something himself.

Improve this answer
1

First off, Code Review is not compilation -- it is not used to check syntax, but rather logic and design patterns/conventions. And while there are design patterns that are somewhat platform/language specific, there are more that aren't. Your developers should pickup enough of the syntax in order to be able to aid in spotting both logic and design issues.

Basically I think this is a non-problem -- instead, I think it's an opportunity for your Java developers to get their feet wet in the language while providing good service.

Improve this answer

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge that you have read and understand our privacy policy and code of conduct.

Not the answer you're looking for? Browse other questions tagged or ask your own question.