Sometimes my project has multiple pull requests. I don't know what is the proper process to handle it.
Currently what I do is
- Review each pull request.
- check code looks ok, and all comments were treated
- check if travis-ci passed and if github can auto-merge the request
if all of the above is correct, I accept the pull request.
However, there is a problem. Once I accepted the first pull request, all other pull requests are actually outdated.
This process encourages mistakes because:
- Travis should check the pull request again, but doesn't
- The developers should update their branch and reverify things work.
But, this process is not perfect too.
- The process creates a bottleneck on merging pull requests.
- There is no way for me to know when branch was merged - github does not indicate that "this pull request is 1 commit behind". So it requires me to do a manual comparison.
- It is hard to enforce or to define as best practice.
My question is - what is the proper way to handle accumulated pull requests on my project?
- Should every pull request be updated if master changes?
- How to make the CI tool (in my case travis) to run again if the destination branch changed as well..