A common scenario in software development is code reviewing somebody else's code. A common tool for doing this is opening a Pull Request.
My question is, when issues are found in the review, should the changes
- be committed separately (new commit)
- or should the existing commit be modified (assuming nobody is branching from your earlier commit... since re-writing history from a shared branch is bad news).
For the first scenario, it's easy to track incremental changes, though it adds some noise to the commit history. The second options has the reverse pros and cons.