Should the author of a changeset be required to obtain sign off from all reviewers who have reviewed the code or should code be allowed to check in as long as there is one sign off? I think giving veto power to reviewers does more harm than good as then they use it to blackmail (asking for unnecessary changes) and block checkins but would be curious to hear people's opinion on this matter as to what is the best practice to follow.
EDIT: Being more specific and to the point, Should a checkin be blocked if:
- there are some people (one or more) who have signed off
- but there are other(s) who have marked the diff as needing revision
- and the author has made a good faith effort addressing comments of reviewers who have marked the diff as needing revision but cannot come to agreement with them?
what do people think?