I'm designing a simple scala wrapper library over a java library in order to make it more idiomatic scala. The problem I faced with is that all operations from the java library could throw an exception, which is RuntimeException, but very similar to IOException. So I'm wondering if it's a good idea to wrap all of them into Either or I should leave it to a user of my library? I guess I should leave it to a user, but I'd like to make sure, that I'm right.
2 Answers
If the occurrence is very rare, I would let it propagate. If it is relatively common, I would actually prefer a Future. They are already designed to contain exceptions, and many tasks that fail frequently also tend to benefit from asynchronous execution, like network IO and database queries. It's quite common to see APIs full of functions that return Futures, whereas I've never seen one that makes heavy use of Eithers.
answered Feb 14, 2017 at 14:05
Depends on your target audience. If you're aiming for the more FP side of the Scala community, exceptions for anything but critical failures are unacceptable - they make for unsafe code. I'd wrap errors in an Either, or at the very least a Try. Preferably an Either, since they don't hardwire failure onto exceptions and are properly right biased in recent versions.
If you're aiming for the more intermediate / OOP side of the Scala community, exceptions are fine, that's what's usually expected.
answered Feb 14, 2017 at 17:48
RuntimeException, but by its meaning it's very similar IOException.