Is it ok for Repository Pattern to contain unusual method names?

Question

For example I need to find a user which its status is 0 and its name is John. So beside usual methods for a Repository pattern (e.g. find, create), I decide to create a method in UsersRepository called findJohnWithStatusZero or to be more generic, a method called findUserWithStatusAndName

UsersRepository.php

<?php

class UsersRepository
{
    public function create(array $data)
    {
        //
    }

    public function find($id)
    {
        //
    }

    public function findUserWithStatusAndName($status, $name)
    {
        return User::where('status', $status) -> where('name', $name) -> first();
    }

}

Controller.php:

...
public function index(UsersRepository $users)
{
    $john_zero = $users -> findUserWithStatusAndName(0, 'john');
}
...

I want to know, if I use these customized methods in my Repository, do I violate the Repository Pattern principles?

Edit: I provided more generic method name instead of findJohnWithStatusZero

Answer 1

At the repository level I would recommend having a more generic method like Find(User user) or findUserByNameAndStatus(name, status). Getting overly specific like your example is unlikely to be a useful method for re-usability, and it's probably embedding business logic into your repository that is better implemented elsewhere. Specific methods aren't bad in a repository, but you should be able to answer why findJohnWithStatusZero is a method, but not findSaraWithStatusTwo, will you eventually need findBillWithStatusOne? It should generally be obvious why a method in your repository exists.

Answer 2

This is typically solved using a search() function.

public function search($searchModel)
{
    return User::where('status', $searchModel->status) -> where('name', $searchModel->name) -> first();
}

class SearchModel { 
    public $status = 0; 
    public $name = NULL;
}