Linked Questions
18 questions linked to/from Where did the notion of "one return only" come from?
20
votes
7answers
3k views
Should a function use premature returns or wrap everything in if clauses? [duplicate]
Possible Duplicate:
Where did the notion of “one return only” come from?
Which is better? I see pros and cons for both, so I can't really decide on which one to stick to.
Wrap in if ...
2
votes
2answers
10k views
Python - only one return per method? [duplicate]
I'm trying to sort out whether this is just a personal preference thing or whether it's actually bad practice to do this one way or another. I did try to reference PEP8 first, and I did not see an ...
2
votes
1answer
716 views
What are the pros and cons of temporary variables vs multiple returns [duplicate]
Take the following examples:
public static String returnOnce() {
String resultString = null;
if (someCondition) {
resultString = "condition is true";
} else {
resultString ...
4
votes
1answer
386 views
Should methods always return from one place? [duplicate]
Possible Duplicate:
Where did the notion of “one return only” come from?
I got into a little argument with a coworker about whether a method should be written like this:
public Thing getThing(...
302
votes
19answers
180k views
Should I return from a function early or use an if statement? [closed]
I've often written this sort of function in both formats, and I was wondering if one format is preferred over another, and why.
public void SomeFunction(bool someCondition)
{
if (someCondition)
...
59
votes
11answers
58k views
What characteristics or features make code maintainable? [duplicate]
I used to think I knew what this was, until I really started thinking about it... "maintainable"... what exactly makes code maintainable?
To me, if code must be maintainable that means we can expect ...
23
votes
7answers
50k views
Avoid too complex method - Cyclomatic Complexity
Not sure how to go about this method to reduce Cyclomatic Complexity. Sonar reports 13 whereas 10 is expected. I am sure nothing harm in leaving this method as it is, however, just challenging me how ...
20
votes
7answers
2k views
Should “else” be used in situations where control flow renders it redundant?
I sometimes stumble upon code similar to the following example (what this function does exactly is out of the scope of this question):
function doSomething(value) {
if (check1(value)) {
return -...
26
votes
5answers
2k views
Are there any scientifically rigorous studies of coding style principles? [closed]
Is a coding style principle - e.g. the single-exit principle - really a good thing? Always, or just sometimes? How much difference does it really make?
Whatever your opinions, these are obviously ...
2
votes
6answers
978 views
Stacking keywords on top of each other - poor style? [closed]
I have always wondered about this, especially in C/Java style languages. For example, consider the first 3 lines of this C# code:
lock (serviceLock)
using (var client = new ServiceClient())
try
{
...
7
votes
5answers
892 views
Why are people coding “C-style C++”?
In discussions about whether to cast the result of malloc or not when coding C, one common argument is that if you cast the result then you can compile your C code with a C++ compiler.
Why would one ...
3
votes
4answers
545 views
Alternative to nested-if on single return functions
I'd like to see if there has been any precedent on alternatives to nested-ifs--particularly for error-code returns. My workplace requires one return per function, so I cannot early exit. Here is some ...
1
vote
2answers
342 views
What is the cleanest way of writing a function with conditional statement with many returning options?
Maybe that's simple, but I'm a little confused.
I have such a Ruby code:
def my_function(found_objects)
# ...
if found_objects.second
return CoreObjectFactory.get_object(found_objects.second,...
2
votes
4answers
227 views
function exit condition on parameter consistency check [duplicate]
When checking for parameter consistency a the top of a function body, what is the best strategy?
This one:
protected void function(Object parameter)
if (parameter == null)
return;
...
4
votes
2answers
188 views
Return type declaration and checks
I've been mainly programming PHP, and I recently started with C++.
In PHP the return of a function can be of any type, so you can do checks like this:
public function doSomething()
{
if (! this-&...