2022 Developer Survey is open! Take survey.

Questions tagged [code-reviews]

This tag is for questions about the practice of code review and code walkthroughs. For reviews of existing, working code, please see http://codereview.stackexchange.com

Filter by
Sorted by
Tagged with
0 votes
2 answers
97 views

Workflow for splitting large pull request into multiple reviews

Nobody wants to review a large PR from one go. The issue is to split a (relatively large) feature into multiple smaller PRs. The rules of the game are This is a single feature, which cannot be ...
user avatar
  • 2,501
0 votes
6 answers
253 views

Is it necessary to understand the requirements of a change in order to perform an effective code review?

Can an effective code review be performed without first understanding the intent behind the code?
user avatar
0 votes
3 answers
141 views

How to manage pull request review and approvals

In our team we have a recurrent problem that we are not able to solve. As long as the team grows, we tend to accumulated PRs at the end of the sprint / release and these become a bottleneck to advance ...
user avatar
0 votes
2 answers
247 views

How to review a PR where I think the complexity is gratuitous?

I am in this situation where I have to review pull requests (PRs) from one of my colleagues, who has a very broad knowledge and years of experience, she is well respected and we all know that the ...
user avatar
2 votes
4 answers
439 views

If PRs are not being approved, when do you stop branching off of master?

I prefer to create linear git history, which can be fast-forward merged. This was a technical requirement at my previous job, which used BitBucket and required all PRs to be fast-forward-able. We had ...
user avatar
1 vote
2 answers
212 views

How to handle code reviews on a collaborative feature branch

We are using GitHub as our source code repository along with Visual Studio. We are going to start to use the GitFlow branching model, so a new feature request will be branched off and worked on in ...
user avatar
  • 121
1 vote
3 answers
261 views

How can we reduce the PR load on our team?

We are using microservices(read a lot of GIT repositories) and our department has 90+ java developers. All of them write code which mean there are a lot of PR`s every day. We are using BitBucket and ...
user avatar
  • 119
2 votes
1 answer
61 views

How to evaluate the impact of change for a single line of code or a variable?

During unit testing it is possible to estimate the code coverage to see which share of the code base is covered by the tests. For one part (the simple calculatable one) of a risk estimation we need to ...
user avatar
  • 129
3 votes
4 answers
297 views

how to perform code review among different types of developer?

My develper team includes Android, iOS, PHP, Web Front, .Net developers, but every type of developer only 1 person, and they don't know other's programming languages very well. We have setup Jenkins ...
user avatar
  • 147
0 votes
1 answer
73 views

Understand implementation of exponential moving average (in case of unix load average)

The UNIX load average gives 3 numbers over 1/5/15 minute time intervals. It's supposed to be an indicator of how busy a UNIX machine is. The global load average is an exponentially decaying average of ...
user avatar
  • 337
7 votes
3 answers
361 views

How to get code review on hobby project?

In my spare time, I like to develop various small libraries and CLI utilities that solve a real problem I have, but are also likely useful to other people with the same use case. When I say small, I ...
user avatar
0 votes
3 answers
186 views

A lot of modifications in pull requests

I would like to know how manage a type of pull requests. One of my reviewers ask me for a lot and a lot of changes (3 or 4 days doing changes), all related with possible improvements in the code that ...
user avatar
  • 135
-1 votes
1 answer
64 views

Design suggestions for my simple data-analysis program

I need to create a program with the purpose of cross-referencing personal info from a spreadsheet(s), to check for conflicts of interest between clients of 3 different law firms. All of this client ...
user avatar
  • 99
37 votes
17 answers
9k views

How can I defend reducing the strength of code reviews?

I have started in a new team. I have 20 years experience as a developer, and I have been in the role of a team lead in several projects. Normally I am very much pro code reviews, but I ended up in a ...
user avatar
  • 520
32 votes
3 answers
8k views

What is the best way to code review a work-in-progress?

I am working on a feature with a system that I am unfamiliar with. The feature is not ready, but I want to show the code to my team (who is familiar with the system) so they can give me early ...
user avatar
  • 1,406
1 vote
1 answer
81 views

Identifying Risks/Gotchas When Using Static

I am intending to come from the perspective of development choices, code reviews, and general testing against defined environments (Development, Test, Production, etc.). I will be using C# as the ...
user avatar
9 votes
2 answers
515 views

Where is the value of online diff code review?

I recently joined a team who are using github Pull Request feature as the single code review tool. In previous teams, I was used to reviews done on a fully checked-out code base, done using IDE tools, ...
user avatar
  • 1,040
4 votes
8 answers
631 views

How to scale code reviews

My boss say we should find a way to scale code reviews at our company. As it is right now, we have about 16 software developers spread across 4 different teams/squads, but soon the company will close ...
user avatar
-4 votes
1 answer
141 views

Python: Help with replacing list comprehension with generators [closed]

I have written the following code which takes a coord_list of points in a 2D coordinate system, a center and a radius and returns a list of all points from the list having distance at most radius from ...
user avatar
2 votes
1 answer
414 views

How do pull requests fit into a development process?

In my software engineering career I have never worked with pull requests. Probably because I only ever worked in relatively small teams (5-16 people) and only on projects that were structured well ...
user avatar
0 votes
1 answer
137 views

Code review patterns for multiple teams working on a single product

We're scaling out development on a single product from a single team to multiple teams. What are the patterns to ensure coding style, patterns and technology is used consistently? Is there one person ...
user avatar
  • 587
68 votes
8 answers
14k views

In code review, should I ask to do a refactor outside of the scope in a pull request?

I have been studying the best practices for a code review, and I was wondering what to do in the following scenario: During a code review, I see potential improvements, but decide that they are ...
user avatar
  • 807
4 votes
1 answer
239 views

Files moved and modified in one pull request

Sometimes I get to review a bunch of files that have been moved and modified. In GitHub I cannot find a way to see what has been modified. Everything looks like a new file. It makes review harder ...
user avatar
  • 650
1 vote
1 answer
220 views

Cyclomatic complexity vs repeated code

we've a python function that can be achieved in 2 ways 1st method def complexity_1(x, y): if 2 == x and 3 == y: a=3 b=4 c = a + b elif 2 == x and not 3 == y: a =...
user avatar
-3 votes
2 answers
102 views

Inspection code reviews, is it outdated today?

I'm a big proponent of peer reviews on every change, like with pull requests etc, however I'm questioning if this type of review alone is enough. For one, I have trouble with reviewers 'missing the ...
user avatar
28 votes
14 answers
9k views

Ways to explain code when told it doesn't make sense

As a programmer I have found my code frequently elicits the reaction "I don't understand". Whenever I get this response I try my best to explain my code patiently, and not make anyone feel ...
user avatar
  • 430
-1 votes
1 answer
90 views

What is the most effective way to explain code in a code review using a pull request?

I work for a small company with only three programmers (including myself). Our workflow is: We write the code; We create a pull request on Github; We ask for code review; We merge the pull request. ...
user avatar
-1 votes
2 answers
87 views

Code Review for Automated Unit Tests [duplicate]

Writing automated unit tests is followed as a part of our development process. We also do have an established code review process for the development code that is written. Should the test code be ...
user avatar
  • 107
-2 votes
1 answer
202 views

How to react to a code pair reviewer pointing out way too many small details [closed]

I recently came to a situation where I could not really figure out how to react. During a project, in a paired code review, the software architecte began pointing out even the smallest detail of my ...
user avatar
6 votes
2 answers
727 views

How to avoid code review bottlenecks when some of the team pair program

There is a school of thought that describes code reviews as the number one priority activity for all developers in a sprint since they are either: a) A source of unrealised value b) A source of bugs ...
user avatar
  • 9,607
3 votes
3 answers
527 views

Isn't keeping the master branch intact essential for collaborating?

I've read a lot of useful articles about collaboration with git. Many do's and don'ts, etc. For example, Top ten pull request review mistakes and a nice article about git workflow The Perfect Code ...
user avatar
6 votes
4 answers
764 views

Code reviewing nitpicks for readability [actually for DRY]

I was doing a code review today and noticed that the code would work but could have easily been made more readable. The example in particular was roughly as follows: def group(x): GROUP_ALPHA = (...
user avatar
  • 170
11 votes
4 answers
932 views

How to review sql changes more effectively? [duplicate]

From my experience, sql code changes almost always tend to be NOT incremental: someone creates a new stored procedure, or modifies an entire embedded sql query for optimization purposes, or creates a ...
user avatar
  • 235
4 votes
2 answers
681 views

How To Get A Junior Developer To Stop Bikeshedding [closed]

I'm having an issue with a junior developer bikeshedding PRs. They are the primary approver for one repository. Things that should be up for an hour or minutes on PR spend days sometimes with back-and-...
user avatar
  • 475
2 votes
1 answer
1k views

Request changes to a commit message during code review on GitHub

I am trying to teach good engineering practices to my team, and in particular, walking them through the basics of PRs and code reviews on GitHub. One of my team members has sent me a request to review ...
user avatar
-2 votes
1 answer
728 views

What is the meaning of 'code vetting' in Software Engineering? [closed]

I saw the term code vetting for the first time in a gerrit review page. What does it mean? The line I came across: "No XYZ check was done. However, if this project is intended to be shipped in ...
user avatar
  • 113
-1 votes
1 answer
123 views

Should one create code review for an incomplete unfinished change? [duplicate]

Had this happened: A developer make a new feature, but not working, since last year, total code change is 100+files and 10k lines. Until recently, with help of another developer, get it to work. ...
user avatar
  • 193
3 votes
0 answers
429 views

Gerrit: Working around the "single-change:single-commit" principle. Need Feedback

I have been using Gerrit in my work environment and I find it really amazing and powerful because of its elegant use of git's branching features to create virtual branches for code reviews (the "refs/...
user avatar
0 votes
3 answers
510 views

Code Design: Repeatedly doing the same Boolean check with Stream Writer

I have several areas in a program where I am doing the following check on the same two booleans, but each spot has different text being written to a file via Stream Writer based on the value of the ...
user avatar
  • 11
3 votes
1 answer
446 views

How do I do code review for an unfamiliar code base? [duplicate]

I work with a small team of software engineers. Each one of us handle different projects without much interaction. We all report to the same supervisor who more or less understands the requirement ...
user avatar
  • 1,337
1 vote
3 answers
847 views

Code design: introduce new method vs add optional parameter to existing method

In JavaScript (ES6), I can have optional function parameter with default value. So to add a new behavior to the existing code base, I could either introduce new method(s) or extend the existing method ...
user avatar
  • 55
6 votes
5 answers
1k views

Assigning people to code review

My team has a problem with making code review. Everyone is constantly busy with their tasks and only few of developers do review on a daily basis. As every merge request needs 2 approvals, some of ...
user avatar
  • 81
0 votes
1 answer
63 views

Removing unused directives from a file which is not related to the pull request [duplicate]

I'm actually working on the web application which was made using technologies such as asp.net core, c#, angular, ef core. For the version control and CD we use Azure DevOps. As a team we try to follow ...
user avatar
  • 101
3 votes
2 answers
756 views

How to distribute code reviews workload in a small team?

I have a small team where I'm largely the only person who reviews what goes into production and makes sure that the code introduced doesn't contradict business logic, no bugs etc.. I know a lot of ...
user avatar
  • 551
2 votes
1 answer
231 views

PHP - Dynamically apply parsing rules to text, and save to dynamic fields

OK, so I have been at this problem for the last few days, and I must admit - I am stuck. I am trying to make a web application, where users can upload documents or send inbound e-mails. Each ...
user avatar
1 vote
1 answer
433 views

PHP - Designing a rule based parsing engine

Dynamically apply methods/"rules" to documents I hope someone here can help me/guide me in the right direction. I am currently creating a web application, where users can import a text file, ...
user avatar
2 votes
1 answer
222 views

How to set up code reviewing in a naive team? [closed]

I am working somewhere where programming is an important part of the job, but where code review is something nobody ever heard of. Being kind of enthusiastic about programming, I've seen a lot of ...
user avatar
  • 187
65 votes
12 answers
12k views

Having a flag to indicate if we should throw errors

I recently started working at a place with some much older developers (around 50+ years old). They have worked on critical applications dealing with aviation where the system could not go down. As a ...
user avatar
  • 707
2 votes
0 answers
94 views

Perspective based reading - Artifact created

From what I have learned, in Perspective based reading, the document/code/etc., is inspected from different perspectives. We consider roles like software designer, tester or user. Each role follows ...
user avatar
  • 339
0 votes
1 answer
162 views

Chain function calls which return error codes or 0 on success in C [closed]

I used to call functions which returns int error code or 0 on success like this: int tmp = function_a() ?: function_b() ?: function_c(); if (tmp) handle_error(); Now I'm ...
user avatar

1
2 3 4 5
7