The encapsulation tag has no usage guidance.
5
votes
5answers
330 views
Separation of concerns: When is it “too much” separation?
I really love clean code and I always want to code my code in the best possible way. But there was always one thing, I didn't really understand:
When is it too much of "separation of concerns" ...
2
votes
1answer
128 views
OOP Encapsulation Philosophy
Is it fair to say that it is good practice to default everything to private up when defining a class?
For example, for my public interface I would set my class something like this:
class foo {
...
7
votes
5answers
509 views
C# encapsulate field is a violation of YAGNI
Consider these two ways to declare a field in a C# class
option A
public class AuditController
{
public DataAccess Service;
}
option B
public class AuditController
{
private DataAccess ...
0
votes
1answer
59 views
API DESIGN: Store Table of function pointers in client or dynamically in api service
FIRST AND FOREMOST: Forgive me if the following question falls into the "off topic" category of this StackExchange, due to its slightly opinion polling nature. This is not my intention, I am simply ...
1
vote
1answer
50 views
Ensure encapsulation and Open/Closed principle with Command pattern?
I'm developing a small multiplayer game. It'll be served by one websockets server and consumed by multiple consumers. As such I need to be cautious about concurrency errors.
The general software ...
0
votes
0answers
41 views
Dependency injection and data encapsulation
Let's say I have Game class. This game class gets constructed with all its dependencies by Game(ITimer timer, IPointsUpdater updater). When the timer raises Elapsed the updater calculates the user's ...
4
votes
4answers
224 views
A problem of decoupling
This is a simplified version of a problem I'm facing in my current project.
Let's say we want to display shapes: rectangles, circles, etc. I'll have a Shape class which is subclassed by Rectangle, ...
3
votes
4answers
129 views
What is the best practice for a regression test that wants to know about encapsulated information?
Suppose you have two classes: Alpha, and Bravo.
Alpha constructs a new Bravo class during its own constructor and exposes no public visibility to it.
Bravo has a String named charlie (and a method to ...
2
votes
4answers
283 views
Use of static methods to implement logic within a class
I've recently caught an odd behaviour in my own coding: At some point in the last year I began creating protected static methods to implement the logic of my public methods, ensuring that the ...
-1
votes
1answer
139 views
OO Class Design for ATM card
I have to design a Class for ATM cards with the following attributes:
Cardholder Name
Card Number
Pin
Other than getters and setters, I have a method to validate the pin of the ATM. As per the ...
1
vote
2answers
156 views
Should we use guard clauses in a method using auto validated properties of an object?
Let's say I have a class like this:
public class MyClass
{
public string A { get; }
public string B { get; }
public string C { get; }
public MyClass(string a, string b, string c)
...
1
vote
1answer
90 views
Rest api manager encapsulation required or not
I am currently designing a software in which I have to use a rest client. I have decided to use a particular library, but am stuck whether I should use it directly or add a custom encapsulation layer. ...
4
votes
4answers
397 views
Is it appropriate to process a property in the setter?
I have a class with a Name property, where the name is set by the end-user. In order to ensure compatibility with the rest of the environment, and to avoid rejecting a lot of inputs, some processing ...
1
vote
3answers
573 views
Is the Liskov Substitution Principle concerned with protecting state invariants?
Wiki says:
Substitutability is a principle in object-oriented programming stating that, in a computer program, if S is a subtype of T, then objects of type T may be replaced with objects of type S (...
1
vote
1answer
115 views
Encapsulation and SRP
Suppose I have the following requirements:
We organize books by author first name, this might change in the
future.
When ever an Author we carry at our store releases a new book, the
Authors previous ...
1
vote
0answers
123 views
How to create an “internal” api for my library which is not exposed to the user?
Note that my question is not platform specific so that's why I don't add the [kotlin] tag (the code is in Kotlin). If there is a Kotlin-specific answer I'd like to hear about it though
I am working ...
0
votes
1answer
79 views
Store reference to object or specific functions [closed]
Having single (or few) method(s) interface constructor injection should I store in a field a reference to the interface instance passed as is or just necessary "entry point(s)"?
class Client
{
...
3
votes
2answers
508 views
Dealing with a lot of getters and setters
I've already asked "Dealing with a large interface".
I have a further question regarding that situation. It was pointed out to me that I used a lot of getters and setters and so I broke encapsulation....
1
vote
2answers
605 views
Are service objects necessary in OOP?
I have been using AngularJs since a long time. Me and my team makes heavy use of services for retrieving the remote resources like Users which intern uses $http service so, basically, for each entity, ...
7
votes
4answers
423 views
Encapsulation and Displaying Information
This site and SO contain many pages about getters/setters and if they break encapsulation or enforce it. My question is for those developers that agree that getters/setters break encapsulation and ...
2
votes
2answers
134 views
Implementation wise fields per object in a class composing a collection of objects
Context
When implementing a class, there's a distinction between fields that are there because they are part of what the object is and fields that are there because they are needed to implement the ...
4
votes
4answers
446 views
How exactly are getters and setters defined?
Note: Questions with similar title have been asked before, but please read the full text before claiming that this is a duplicate.
Since everybody in OOP uses the terms getter and setter, I would ...
6
votes
10answers
1k views
Why combining getters, setters and private access modifier is not enough to hide implementation?
In Clean Code:
public class Point {
public double x;
public double y;
}
The author wrote about the above Point() class:
This exposes implementation. Indeed, it would expose implementation
...
6
votes
1answer
204 views
In more canonical OO Python situations, what is the rule of thumb for default access modifiers?
Generally speaking in canonical OOP situations, the rule of thumb is to write your classes with the least access as necessary. i.e. only make public only what is necessary, make protected only what is ...
1
vote
2answers
191 views
Does changing the private member of a class through an overloaded subscript operator break encapsulation?
I have always been taught that in order to in-keep with encapsulation objects should be responsible for performing calculations on their own data.
So in this case here is this breaking rules of ...
3
votes
1answer
182 views
Is it always optimal to preserve encapsulation in MVC?
I've just finished up a project in which I created a visual simulation of the life cycle of an ARM instruction in a single cycle processor. I used the MVC pattern in this project and ran into a design ...
-2
votes
2answers
396 views
Is 'List' a leaky abstraction?
Abstraction - Creates barrier between representation & usage of List ADT
Encapsulation - Ensures maintaining in-variants of List ADT.
An invariant is a fact about a data structure that is ...
22
votes
4answers
3k views
What does it mean when one says “Encapsulate what varies”?
One of the OOP principles I came across is: -Encapsulate what varies.
I understand what the literal meaning of the phrase is i.e. hide what varies. However, I don't know how exactly would it ...
0
votes
2answers
64 views
Use XmlDeserializer in factory method?
I have the following class representing an XML configuration stored in the DB:
using System.IO;
using System.Xml;
using System.Xml.Serialization;
[XmlRoot("ModalConfiguration")]
public class ...
2
votes
1answer
616 views
Do singletons use encapsulation?
I'm reading the Design patterns book by the Gang of 4. Does a singleton use encapsulation? To me it would seem like yes, but i'm not 100% sure. Maybe I don't have a good understanding of ...
4
votes
1answer
121 views
Does InternalsVisibleToAttribute indicate a bad design smell?
Every time I have used the InternalsVisibleToAttribute when developing an API, it feels a bit smelly. Like the API is not being designed in a truly encapsulated way. A lot of the times this is out of ...
-2
votes
2answers
465 views
C++ Which of the following is a better singleton pattern approach?
I'm now stuck in the server I am programming, simply because I do not seem to find a good and realiable way to handle my "single object" classes, I've attempted the Singleton pattern but it is just ...
0
votes
1answer
679 views
Should I always use prefix private methods with an underscore in Python?
Prefixing methods and members with an underscore indicates internal use. For simple classes, I sometimes find the easier reading and typing of self.foo outweighing the indent of self._foo. Especially ...
1
vote
1answer
366 views
Inner and outer class relationship: should outer class be friend of inner's?
Is this design bad?
Does it break encapsulation? The structure class B is a component of class A. Therefore, class A needs access to class B's members. Let a house be class A. Let a housekeeper be a ...
1
vote
2answers
279 views
Private fields and encapsulation
I'm reading the head first c# book and don't quite understand what this means.
"Any class can see private fields in another instances of the same class"
1
vote
1answer
77 views
Chain accessors or return the value of private pointer
hopefully the title isnt too confusing, I am having trouble thinking through what best-practice dictate I do in this situation.
Say I have the following class structure
Class A {
public:
bool ...
16
votes
10answers
2k views
Do you generally send objects or their member variables into functions?
Which is generally accepted practice between these two cases:
function insertIntoDatabase(Account account, Otherthing thing) {
database.insertMethod(account.getId(), thing.getId(), thing....
1
vote
2answers
994 views
Don't auto-implemented properties violate encapsulation?
In C#, when a field getting or setting requires logic, we use properties. For example:
private int _age;
public int Age
{
get
{
Console.Writeline("Club member is {0} years old", _age);...
31
votes
5answers
7k views
Why do we need enums in dynamically typed languages?
I was reading some code here and saw that an enum is used to store names of html tags. Why do we ever need to do this? What benefit do I get using this strategy?
I know that how useful enums are in ...
1
vote
1answer
119 views
Should I actually be using encapsulation here?
Problem Statement
I am going to write a library to control a whole bunch of relays, and I am just trying to think conceptually right now.
Here are my design constraints:
We have an exact number of ...
4
votes
2answers
487 views
How far should encapsulation in JavaScript go?
I have a variable which I want to use in only one function. I can write my code like this:
var theAnswerToLife = 42
var multiplyIt = function(x) {
return ++theAnswerToLife * x
}
I have some other ...
2
votes
3answers
309 views
Testing properties with private setters
Currently in a part of my project a domain object like below exists:
public class Address
{
public virtual string HouseName { get; set; }
public virtual string HouseNumber { get; set; }
...
3
votes
2answers
214 views
How do I deal with unneeded inherited members?
Consider the following UML diagram:
In a nutshell:
ChildClass1 and ChildClass2 use all of the members of ParentClass.
ChildClass3only uses Member1 and Member2 and the value of Member5 is a constant ...
10
votes
3answers
6k views
Best practices for using public, protected, private?
Is it fair to say that it is good practice to default everything to private up front when coding something?
And then only upgrade it to protected if a subclass needs it, or public if another class ...
261
votes
17answers
21k views
Why have private fields, isn't protected enough?
Is the visibility private of class fields/properties/attributes useful? In OOP, sooner or later, you are going to make a subclass of a class and in that case, it is good to understand and being able ...
1
vote
0answers
541 views
Data Mapper pattern vs. model encapsulation
I am currently developing my first custom data mapper layer but have run into a conceptual problem that seems to be glossed over all books and guides I have read.
My problem is as follows. My data ...
1
vote
0answers
559 views
Change object state in different point in program
This is not about whether or not getters/setters are wrong. I understand its impact to encapsulation and that question has been raised here and SO several times already. I also do not want to just ...
0
votes
1answer
158 views
Best practice for settings for PHP class for code generation [closed]
I would like to have a class creating any code from given options and output it in a chosen way.
I have written class for generation of simple JavaScript code for such cases where is needed to ...
2
votes
1answer
284 views
Javascript Closure Style Similar to Java Class Structure
PROBLEM: There is a coding imperative (S. McConnel, Code Complete) that one shouldn't code on language, but by means of it, e.g. doing right style things even if language doesn't have some ...
2
votes
1answer
2k views
Passing MVVM objects to other classes [closed]
So I'm using C# WPF and binding to a Model View to display states. The data that needs to be displayed is spread across a couple different classes. For instance I have a class that reads out digital ...
