Stack Exchange Network

Stack Exchange network consists of 174 Q&A communities including Stack Overflow, the largest, most trusted online community for developers to learn, share their knowledge, and build their careers.

Visit Stack Exchange

Questions tagged [pull-requests]

The tag has no usage guidance.

0
votes
1answer
79 views

How to handle complete rewrite of a file in regards to code review

My situation is this: I am contributing to a Symfony/PHP project. I had to completely reskin one page in the application. The controller logic is almost totally unchanged. I only had to change the ...
1
vote
3answers
88 views

Waiting on Multiple GitHub PR Merges

Scenario: I fork a project and submit a PR on Feature A, and then another on Feature B. I want to continue working with both features while I'm waiting for the PRs to be merged (theoretically they ...
1
vote
1answer
105 views

Multiple git users

On GitHub if I want to contribute to another user's repo I clone it, make changes and submit a PR, at which point the owner can choose to merge or not. I am trying to figure out how to create a ...
3
votes
2answers
231 views

Working on issue that relies on changing code

I work in a small team making software, we run pretty close to scrum, tickets and sprints, and use git. I however work in a different timezone, so communication can be a bit disjointed, though ...
1
vote
0answers
50 views

As an author of a Pull Request in TFS, how does the reviewer know the PR needs to be re-reviewed?

I am project manager and I struggle with gaining the attention of the Reviewer of a pull request when the author has replied to a question from the Reviewer. In other words, the Reviewer initially put ...
-1
votes
1answer
66 views

How to Gain full Confidence in Pull Request builds

Having confidence means Pull Request builds (in Jenkins) will finally allow you to merge the code after a Pull request builds successfully and is reviewed. You're 100% confident that it can go into ...
0
votes
1answer
57 views

How to handle pull requests merges in a service oriented environment that touch several repositories?

So we have a microservices architecture. Quite often we release features that require changes in several repos simultaneously. What approaches are best for handling this? Ex. Pull Request 1 from ...
23
votes
4answers
959 views

How to handle a TODO in a pull request?

When I review the changes in a pull request, I sometimes stumble upon a comment with a "TODO" note which may be there for different reasons, in our case mostly because of: the solution used to solve ...
2
votes
3answers
715 views

two level code review using git pull request in BitBucket

The following procedure: We have Development branch and Developer create feature branch from Development Work and commit in this branch Rebase from Development Create pull request Code review Merge ...
0
votes
1answer
3k views

Create a pull request to a tag

If there is tag 1.1 for master branch in github, I want to create a pull request with some commits that only apply to that very tag. Is this possible?
1
vote
1answer
89 views

Benefits for the developer of separating pull requests by logical change?

I am currently responsible for reviewing one of my team mate's code for a front end web app. We have established a workflow which involves creating a feature branch in git for each feature we define. ...
2
votes
1answer
1k views

Should we use Reject or Wait For Author in TFS when there are things to be fixed?

In TFS, when we put comments for things to be fixed in a Pull Request before we will accept it, should we mark it as Reject or Wait For Author? Which is better?
9
votes
6answers
990 views

Are pull requests the place for training juniors

We have a concept that all code in a Pull Request into master should be production ready. This makes sense and is a fair statement in my opinion. The idea here being that once you create the PR, you ...
3
votes
2answers
475 views

does it make sense to create a pull request without code

Background In our start-ups documentation, we got this: Difference between a pull request and an issue page In a nutshell, an issue page should only include information and discussion about ...
0
votes
1answer
153 views

Introducing version control with a simple pull request workflow

I have very little experience of using a version control system and my work colleagues have no experience though I would like to introduce one into our team as the current workflow (non-existent ...
1
vote
1answer
309 views

Git - how to have mixed permissions for merging a pull request into a protected branch?

I know that, on github, you can define a protected branch and allow only certain users to merge a pull request there. Say, for instance, that users A, B, C and D are developers and A is team leader ...
3
votes
1answer
114 views

If I have direct commit access, is there any reason to create a pull request for a small change requiring no feedback?

At my work, we use Git as our version control system. We have a master branch, which I have direct commit access to. Sometimes I have to make a trivial fix, such as fixing a typo in documentation, and ...
13
votes
4answers
2k views

Code review workflow where pull request author must merge

Several teams at my company practice a code review workflow I've never seen before. I am trying to understand the thinking behind it, with the idea that there's value in making the whole company ...
4
votes
3answers
261 views

How soon can/should someone issue a pull request for a new branch?

Pull requests are a great feature of modern vcs hosting. They provide a consolidated view of everything that's happened within a branch's development, including a master diff of the composite change, ...
0
votes
1answer
198 views

Code review and then what? [duplicate]

In my team we have a policy that each code should be reviewed by at least one other developer. When the review is done the reviewer just clicks the merge button so the code ends up in development. ...
10
votes
5answers
3k views

Why use pull requests instead of merging

What is the advantage of using pull requests instead of simply merging a branch into master without one? Particularly on a team where all developers have full access to master.
4
votes
1answer
415 views

How to review a pull request?

Does a pull request review consist of testing, code review or both and how long should the average PR take? I don't know whether the testing just involves testing the functionality that's been ...
6
votes
1answer
343 views

How should my team distribute checking pull requests?

I'm working as part of a team of 10 on an agile project, this is our first time using GitHub. We write our code, create a pull request and then start on our next task. 95% of these pull requests are ...
1
vote
1answer
218 views

How do I organize my project to accomodate GIT pull requests for source installed via PIP?

I want to structure my Python project in a manner such that others can use a package manager (PIP) to easily clone the environment for team development, and GIT to contribute to the project, plus a ...
10
votes
1answer
1k views

Why can't Pull Requests be seriously implemented in Mercurial?

A week ago, I was at LFNW and as I was talking with Larry Hastings after his talk, he said (paraphrased): There's something in Git that makes the Pull Request workflow possible that isn't there in ...
6
votes
1answer
156 views

Why use a dedicated “pushbot” user which automatically merges approved pull requests?

Most Github repositories I'm aware of use the following workflow for pull requests: one or several users with "contributor" privilege review the suggested changes and then one of them merges the pull ...
2
votes
2answers
476 views

Pull requests and work item linking in Visual Studio 2015 with non-TFS remote Git repo

We use TFS and Visual Studio 2015 at work but don't get full benefit from the ALM features as we have code in non-TFS Git repos. We would like to integrate these products in with all the TFS goodies ...
6
votes
2answers
4k views

Is it better to start a Pull Request or perform a local merge commit on master?

I have been using GitHub for quite some time now and I usually used to push my feature-branches and then start a Pull Request which I myself merged. I found it helped me keep track of where I merged ...
2
votes
3answers
545 views

Getting a Candidate to do a Pull Request Review in an Interview [closed]

I was wondering if somebody has done this, and to what success compared to the classic method of getting them to solve a problem as you watch on? Any pointers on how to carry this out in an interview ...
12
votes
1answer
3k views

How to do peer reviews on GitHub pull requests?

We're moving from Bitbucket to GitHub and one thing we are struggling with are peer code reviews that worked very smoothly on Bitbucket like this: Author opened a Pull Request (GitHub: the same) ...
3
votes
2answers
249 views

What to do with the code from my rejected pull request?

I just recently sent off a pull request to a small but well-known open source project. This pull request added a new feature, as well as unit tests (and improvements to the existing tests). However, ...
1
vote
1answer
163 views

What's the proper way to organize and revision a pull request

I'm working on an open source project for the first time and I'm adding a feature to the source. The way I've been going about, is I've squashed my individual commits into on clean commit for the ...
10
votes
1answer
736 views

Introducing Pull Requests for a 2 person team - merge my own requests?

I'm introducing git to a junior team member (a co-op). They are comfortable now with the basics of adding, committing, pushing and pulling. Now I want to introduce them to pull requests and branches....
4
votes
1answer
173 views

How to reconcile “misc fix” commits with pull requests?

I work in a small company, where I used to be the only developer. We recently welcomed a few other people on the team, and started thinking about how to organize development efforts. I am pretty much ...
6
votes
1answer
1k views

Should I accept pull requests that are behind master?

Sometimes my project has multiple pull requests. I don't know what is the proper process to handle it. Currently what I do is Review each pull request. check code looks ok, and all comments were ...
155
votes
5answers
27k views

Why squash git commits for pull requests?

Why does every serious Github repo I do pull requests for want me to squash my commits into a single commit? I thought the git log was there so you could inspect all your history and see exactly what ...
3
votes
2answers
2k views

What is proper order of pull requests and testing?

We want to setup proper development workflow. We have two main branches: master(release branch) and develop(working branch). We want to use pull requests properly. We see two ways how to do this: The ...
6
votes
1answer
2k views

Why aren't there cherry-pick requests?

One disadvantage to pull requests (aka merge requests) is lots and lots of merge commits. It's not the worst thing, but it does clutter the commit logs, and make for lots of unnecessary non-...
5
votes
2answers
481 views

How to handle versioning with multiple independent pull requests in a Git repository?

Let's say Alice has a Git repository, and the version is kept track of inside the repository (let's say package.json for npm). Bob sends a pull request to Alice which increments the version number ...
1
vote
1answer
969 views

Dynamic git URL for Jenkins builds

We internally use GitHub Enterprise and Jenkins. If I push on the main repository it is automatically build without and the Commit is marked as correct (just as Travis does this). However, I want to ...
2
votes
2answers
844 views

Should I fork a fork (on Github)? [closed]

On Github, I've run across a pull request which it implements a feature I like but feel isn't quite intuitive and could be better. The maintainers of the original repo have so far declined to accept ...
17
votes
1answer
1k views

My github pull request was merged, what's the convention at this stage?

I forked a project on Github, made a small change and sent a pull request to the original maintainer, who has pulled it in. Now the last commit there is Merged pull request #11 from my_username/master....
0
votes
1answer
199 views

Should I open pull requests from a branch on the official repo or my fork?

I have commit access on an open source project named Foo hosted on GitHub (there are many other committers if that is relevant). I would like to make a change via pull request so that someone else ...