Questions tagged [refactoring]
Refactoring is a disciplined technique for restructuring an existing body of code, altering its internal structure without changing its external behavior.
731
questions
-1
votes
2
answers
218
views
4 Months of Code Rewritten in 2 Days Team Dilemma [closed]
I recently had a project that I took me 4 months to do , I hit some very significant bugs that where impossible to track down. I said this code is absolute garbage and started from scratch, drank a ...
1
vote
3
answers
167
views
Handling a Refactoring Project with Limited Access to Source Code
I recently finished an interview with a company as a web developer. I'm the first and only developer that is about to be hired in this company.
They have a web application that was created by a ...
3
votes
5
answers
616
views
Is "avoid feature envy" violating "open closed principle"?
After reading
What is a" feature envy" code and why is it considered a code smell?"
I know the following code is suffering from "feature envy":
public class Garden{
...
3
votes
2
answers
329
views
When refactoring many functions that share state in to a single class, how can you avoid writing an "escort" class?
This well-known article criticises Java on the basis that it does not allow you to write functions that do not live in a class. This flaw forces you to write classes with names that look suspiciously ...
- 997
2
votes
6
answers
592
views
How do I determine how long a refactoring effort will take?
After much hard work, I've convinced my manager that some absolutely awful code needs refactoring. As with any project, they've asked me for a time estimate and I've found myself stumped. How can I ...
- 997
0
votes
2
answers
194
views
How to refactor this tightly-coupled method and (mostly) preserve its encapsulation?
I have recently encountered this problematic method (minimal reproducible sample in C++ but this question aims to be language agnostic past the syntax):
void MyObject::twice_bind_cycle() {
_bind1()...
- 17
0
votes
4
answers
278
views
Object matching using generic method? [closed]
I have a piece of code where two objects (incoming request object and a profile object) are to be checked for matching conditions.
So the first method is as below where I check whether the profile ...
- 593
1
vote
2
answers
165
views
Refactor chunks of code where variables from one chunk are used in others
What is a good pattern to refactor a chunk of code where you can identify smaller chunks, but the results of these smaller chunks are used in other chunks?
An example should make things more clear. ...
- 998
1
vote
3
answers
258
views
Is in my case role based access better than permissions?
Hello StackExchange community, I'm in a bit of an impasse for my current project.
The software in question is a collaborative program designed to let employees work together on the platform and assign ...
- 21
0
votes
0
answers
61
views
Refactoring: where should master data reside?
I inherited a backend project and want to refactor the management of master data. The master data consists of a couple of database tables that contain fields like year, rebate_in_percent or category.
...
- 11
13
votes
4
answers
2k
views
How should factored-out code be tested as part of the TDD refactoring step?
When in the refactoring step of a TDD process, if we "factor out" some common functionality from two (or more) code modules, how do we avoid that "factored out" code not being ...
- 243
1
vote
5
answers
400
views
What are some considerations when deciding to fix a bug, or rewrite the code in question?
At some organizations I'm seeing a trend where if a bug is reported, engineers will directly rewrite the offending code without knowing the root cause. In general this will fix the bug, but in my ...
- 127
0
votes
2
answers
228
views
When is it practical to design in advance of refactoring?
I have a colleague that insists refactoring to make the code testable and introduce tests should be independent from changes in architecture as part of refactoring, e.g. introducing a factory pattern. ...
- 136
1
vote
2
answers
118
views
The name of this change/refactoring pattern
At first, we have a working function name foo
void foo() {
bar1(9);
bar2(9);
}
Noted that the value 9 is hard-coded. Then, we want to make a change so we can make 9 a parameter yet preserving ...
- 965
0
votes
3
answers
427
views
How to deal with an actively developed 20 year old legacy codebase [duplicate]
I know there are potential duplicates, but imo this is different because there are around 100 developers actively working on this nightmare.
I have unfortunately gotten into a job where this GUI ...
- 55
0
votes
0
answers
47
views
Refactor conditional multiple AND OR operations? [duplicate]
I have a piece of code where two objects (incoming request object and a profile object) are to be checked for matching conditions.
So the first method is as below where I check whether the profile ...
- 593
-1
votes
2
answers
178
views
Performance hit after non-functional refactoring
I was asked to refactor some C++ code recently for the purposes of increasing unit testing coverage. The problem was that the code was tightly coupled on one compilation unit, so we had the equivalent ...
- 223
-2
votes
1
answer
220
views
How Should I Go About Refactoring My Code With Dependency Injection? [closed]
I work on WPF applications used in testing hardware. I need to make my code base more testable and re-usable. I believe DI would help, but I'm not quite sure where to start. I've done my best with the ...
0
votes
1
answer
117
views
Correct way to deduplicate conditional statements [closed]
I'm facing with problem that in every function (with serves as service for endpoint) I need to check what is value of query parameter (mode). I need to check it on many callables, E.g.
def create(self,...
- 111
0
votes
1
answer
437
views
Unit tests and mocking when functions arguments have changed?
I'm learning how to write unit tests on a project I'm doing with my friends. One thing we tried was to mock the return values of function calls if the functions are declared in a different "...
- 147
0
votes
1
answer
72
views
Better design for a REST import into web store
I have an import that needs to grab data from a REST service and import into an web store. It's basically an ETL type of service, but because the REST service can be slow and I don't want to call it ...
- 119
1
vote
0
answers
192
views
What design pattern does this implementation follow?
For a middleware solution I expose an API, which processes data and sends the necessary information to different parties.
In the current design we create a new client, which acts sort of like an ...
- 29
0
votes
2
answers
320
views
Debugging to track attribute change
I have a very large C++ application running on a *nix environment, which is occasionally setting a particular date attribute on a structure, way off what it should be. I know which structure and which ...
- 223
2
votes
2
answers
370
views
How to handle duplicate null checks
I'm working with a legacy codebase that has a lot of functions with a nullcheck on the same object. Example:
std::vector<SessionNode*> * SessionManager::SessionMap;
Session * getSession(int ...
- 31
1
vote
2
answers
141
views
Should I add functionality by adding a new method to a class - or should I "register" the new functionality into a data structure?
I have one large class that computes ~50 different metrics (each metric has no side effects).
My code is similar to this:
class ReportingMetrics:
def __init__(self, data:pd.DataFrame, config:dict)...
- 321
-2
votes
2
answers
166
views
When is there a case for refactoring large parts of a codebase at once? (if ever)
I work with a specific engineer (let's call them X) that, even though they have many years of experience in the industry, has a lot of trouble to manage the scope of code changes. For example, say ...
- 11
0
votes
1
answer
227
views
Refactoring business logic out to private methods and testing
I am currently working on a project where there is a class ContactMonitoringJob a Quartz IJob class which in brief keeps pulling from a database and checks if any new changes have been introduced ...
- 55
4
votes
2
answers
280
views
Should I use classes instead of functions with a state needed for computation?
I have implemented the cows and bulls game in C++.
The code:
#include <cstdio>
#include <cstdlib>
#include <ctime>
struct DigitMatches {
int matches_in_right_positions;
int ...
- 51
0
votes
2
answers
239
views
What is the best practice for temporarily pairing an attribute with a class
Consider a case, in which a class needs an attribute only in a very limited context. (For example, only during initialization, which is handled by a factory) I do not want to include such an attribute ...
- 992
12
votes
6
answers
5k
views
Is it bad practice create "alias" variables to not use globals or arguments with long names in a method?
Is it OK to create a variable which only purpose is to increase readability?
Example:
public class Example
{
private final HowLongCanARepositoryNameReallyBeRepository ...
- 245
1
vote
3
answers
496
views
Refactoring a class to an abstract base class - keep default implementation in place or move it to an an other class?
I have a class which aggregates some temporal data from a database and provides a bunch of methods to query said data. It looks like this:
public class InfoProvider
{
public IEnumerable<...
4
votes
3
answers
1k
views
Should I make my class mockable by marking its methods as virtual or by creating an interface?
In the process of refactoring non-testable code we are re-designing some of ours classes so that it can be easily replaced by a stub or mock during unit tests.
Here is an example of such class (...
- 366
0
votes
2
answers
77
views
Restructuring a “processing slip” like object used in many steps
I have worked on a library which processed data through multiple steps. It was written in R, a dynamic programming language where one could just add fields to existing “objects”, which were just ...
- 933
1
vote
4
answers
119
views
Should I public method and test it instead of testing a caller
I have a method called GetValueA() and GetValueB() which return string that in formatted
public string GetValueA(){
string a = service1.GetA();
return Format(a);
}
public string ...
1
vote
2
answers
185
views
Anemic Domain Model VS coupling and dependencies- design conflict - need an Object oriented advice
on design stage , after finding my main objects ,
I am always find my self writing "manager" or "controllers" classes in order to handle the connection between them. some of the ...
- 93
0
votes
4
answers
313
views
Change architecture design to API to reduce coupling
I was reading articles about TDD and I found the following one. https://blog.cleancoder.com/uncle-bob/2017/03/03/TDD-Harms-Architecture.html
In order to answer this question I think someone should ...
- 17
-1
votes
1
answer
102
views
Optimizing methods with multiple if checks on getter values
I have a method where I fetch user input, check if certain values exist, and based on that build my own custom input object that I would use to search in a database. The code for the search method is ...
- 173
2
votes
2
answers
471
views
What methods can be used to simplify mathematical expressions?
For fun, I would like to design a mathematical expression evaluator, with variables. It could simplify the entered expressions by factoring them, reducing them to a sum of simple fractions, ...
- 219
2
votes
1
answer
204
views
Composition or Inheritance for classes with almost similar implementations but different input and outputs for methods?
I have the following classes, which have quite similar method implementations. Only the classes' method inputs and outputs seem to be of different types. When I put it like this, it sounds like a case ...
- 173
-1
votes
1
answer
578
views
rails, how to refactor nest if statements? [duplicate]
I'm working a project where I found another developer wrote a method as you see it below.
How would I clean those IF statements and refactor this method.
Also is it ok ti set a variable to nil ?
def ...
- 117
-2
votes
3
answers
161
views
How to determine if a module within an application is worth refactoring or rewriting?
We all know Joel Spolsky's famous article to never rewrite working code.
How about if we don't consider overall program but a module within? Module can be e.g.:
payment handling microservice in e-...
41
votes
8
answers
7k
views
Getting buy-in for cleaner and more structured code
I am at my company for half a year now and think that I have gotten a fair idea of their codebase. Initially I didn't dare to form strong opinions, but now I start to feel that the code could benefit ...
- 933
2
votes
1
answer
132
views
Resolving lambdas that depend on each other
In the C++20 codebase that I work there are a couple of functions which have helper functions defined as lambdas. I can see the idea of locality for these helpers. By having them there in the function,...
- 933
1
vote
2
answers
540
views
No trivial god-class refactoring
Consider you have the following code:
class UserContainer
{
List<User> user;
//some methods to get specific users, for example users, which are higher than 1,70meters
}
The User have a ...
- 143
0
votes
2
answers
729
views
Good design for a class with multiple methods to test but one public method
I've been trying to refactor some existing code which is in essence a giant nested procedural call inside what should otherwise be an object oriented architecture. The entry point to the relevant code ...
- 23
8
votes
4
answers
2k
views
Use local or nested function for readability?
I found in the catalog of Refactoring by Martin Fowler, with Kent Beck book that they mention Extract Function refactoring.
It is a good practice to wrap your related code into local functions to ...
- 189
0
votes
4
answers
736
views
Refactoring two methods with similar for loops containing some unique logic
Please help me with the following code refactoring, I spent so much time researching it and there's still no clear answer on how to approach it. Any help is greatly appreciated!
So, given 2 methods (C#...
- 11
3
votes
3
answers
804
views
Use inheritance to make single child, smaller
We have a relatively big class. One of my colleagues thinks we must split this class into a base & child class to make it smaller and cleaner.
On the other hand, I believe when we know this parent ...
- 51
1
vote
2
answers
198
views
How to determine that a team is not doing enough refactoring?
I'm working my way through Refactoring: Improving the Design of Existing Code by Martin Fowler and I came across the following passage (2nd ed, p. 55, emphasis mine):
To a manager who is genuinely ...
- 129
3
votes
0
answers
100
views
Refactoring nested if-else statement [duplicate]
I have an app where every object is checked based on various types of business rules. For this, i used multiple nested if-else statement which was done in one class. I am not happy with this situation ...
- 39