28
votes
Are "need to call objects in parent object" and "avoid circular dependency" reasons to avoid "Tell, don't ask"?
Ultimately, you're pushing all the program logic into class Manager. Everything else is only a dumb interface. As the program develops, Manager gets bigger and bigger, until it's an unmaintainable ...
- 9,513
7
votes
Are "need to call objects in parent object" and "avoid circular dependency" reasons to avoid "Tell, don't ask"?
The point is to reduce how much Manager knows. Also, SystemMoniter should only know its things. it shouldn't need to know about Leds, Speakers, or the Screen. And actually, neither should the Manager.
...
- 383
4
votes
Are "need to call objects in parent object" and "avoid circular dependency" reasons to avoid "Tell, don't ask"?
The problem I see here is a good old fashioned coupling problem.
Your 'bad' does too much. Then in 'good' you delegate to something else that also does too much. This is not progress.
public class ...
- 103k
2
votes
For non-container classes, are "better naming" and "ready for commented codes" good reasons not to declare the most abstract type?
Type strategy has nothing to do with what kind of class you're dealing with, it applies to Containers in the same way as to non-containers. If all you do is drive(), then you should deal with a Car ...
- 108k
1
vote
For non-container classes, are "better naming" and "ready for commented codes" good reasons not to declare the most abstract type?
Your problems boil down to two things:
The "most abstract type" depends on what you do with the object
Variable names should tell you what the reader needs to know, not what the compiler ...
- 5,732
1
vote
Is it necessary or "class obsession" (opposite to primitive obsession) to create classes for non-business fields?
If you want to put the dialog showing logic in another class then do it like you mean it.
public class MyActivity extends Activity{
onResume(){
welcome.considerShowingDialog();
}
}
...
- 103k
Only top scored, non community-wiki answers of a minimum length are eligible