33
votes
How to be (more) critical during Code Reviews?
Look for anti-patterns.
Lint the code if it has not already been done.
If something looks really strange, talk to the developer before proceeding--maybe they are not ready to have their pull request ...
- 544
13
votes
How to be (more) critical during Code Reviews?
A code review needs to find and point out any major flaws:
Does the code use the wrong approach to solve the problem? Do the design patterns fit?
Does the code actually solve the problem? Does it ...
- 1,323
10
votes
How to be (more) critical during Code Reviews?
I would suggest:
Have more than one person review a PR - you can compare the issues that you found to what someone else (preferably a senior engineer) found. Talk to the other reviewer to understand ...
- 2,532
7
votes
How to be (more) critical during Code Reviews?
A few points that have not been covered yet:
Is it maintainable and extensible (e.g., uses interfaces, collects configuration values in a visible spot instead of scattering them);
Is it testable (e.g....
- 2,022
6
votes
How to be (more) critical during Code Reviews?
How to be (more) critical during Code Reviews of team members?
Don't be critical of team members. A code review is about code. Not about who wrote it.
I'm active/highly involved with the code, but ...
- 105k
5
votes
How to be (more) critical during Code Reviews?
Don't worry too much about it but definitely strive to improve your code reading skills.
Identifying code smells requires experience. Therefore by its very nature critiqing (rather than being critical ...
- 1,464
2
votes
How to be (more) critical during Code Reviews?
I can be very critical when writing code myself since I'm active/highly involved with the code, but looking at it more passively I'm not very good in reviewing the code
Then involve yourself with the ...
- 4,070
1
vote
How to be (more) critical during Code Reviews?
During
PR
code review we seek to answer a pair of questions about the code.
Is it correct?
Is it maintainable?
Answers of "yes, yes" suggest that we should
merge the proposed edits to the ...
- 4,895
Only top scored, non community-wiki answers of a minimum length are eligible