Skip to main content
The 2024 Developer Survey results are live! See the results
182 votes
Accepted

Should I submit a pull request to correct minor typos in a Readme file?

Just fix all the typos you noticed and create a pull request with a comment along the lines of 'Fix typos'. Then it's one button to click for a person with the correct access. You don't need to ...
RiaD's user avatar
  • 1,700
110 votes
Accepted

If GitHub interacts with Git, and Git is licensed under GPLv2, shouldn't GitHub be open source?

3 reasons why: According to the terms of the GPL, people accessing GitHub via the web is not considered releasing (or propagating in GPLv3 terms), and so GitHub is not required to share their source ...
whatsisname's user avatar
  • 27.7k
83 votes
Accepted

In code review, should I ask to do a refactor outside of the scope in a pull request?

There are several relevant trade-offs here: Review complexity. If a branch has more than one functional change commit or more than one refactoring commit it becomes time-consuming to review the ...
l0b0's user avatar
  • 11.5k
82 votes
Accepted

Should I keep my GitHub forked repositories around forever?

Updated answer: As of February 18, 2021, the “Unknown Repository” issue has been resolved. You should be ok to delete repositories once all the branches have been merged. Old answer: Deleting forked ...
Stevoisiak's user avatar
  • 1,294
81 votes
Accepted

How can I start using Git in a project that is already underway?

My naive approach would be to start a new Git environment, push the whole project into the master branch and then continue to develop the project using Git as if it had been there all along. That ...
bdsl's user avatar
  • 3,776
75 votes
Accepted

Understanding the difference of branch between SVN and Git

I am a user of SVN and now I am learning GIT. Welcome to the gang! SVN Re-education In SVN I usually [...] Hold on for a moment. While CVS and SVN and other traditional (i.e. centralized) version ...
das-g's user avatar
  • 784
73 votes
Accepted

What is the best way to code review a work-in-progress?

GitHub allows for PR to be in a "draft" state. Your team can see the differences, and even comment on it, but it's still obviously a work-in-progress, and cannot be merged until you click a &...
FrustratedWithFormsDesigner's user avatar
56 votes

Should I submit a pull request to correct minor typos in a Readme file?

Some context that may or may not be relevant. A cloud hosting provider named DigitalOcean hosts an event every year called Hacktoberfest to encourage people to contribute to open source projects in ...
Zach Lipton's user avatar
  • 1,608
50 votes

In GitHub flow, is it OK to base feature branch on another feature branch?

Here is the workflow that I follow when I branch from a feature branch: Create feature-branch-B from feature-branch-A Work on feature-branch-B If more commits are added to feature-branch-A after ...
geoji's user avatar
  • 601
31 votes

Understanding the difference of branch between SVN and Git

In SVN I usually checkout on my local machine a repo, which includes all branches in my project and I used to select the folder for my branch I am interested to and work there. Unless you check out ...
l0b0's user avatar
  • 11.5k
30 votes

Declaring multiple licences in a GitHub project

In a presentation of the SPDX creators (slide 12), it is very clear: Contents of LICENSE: Apache-2.0 OR GPL-2.0-or-later You could add two additional LICENSE files then: LICENSE.Apache-2.0 and ...
koppor's user avatar
  • 587
29 votes
Accepted

Should I use git stash to save ongoing changes of my project and push it to github to access in other computers?

I've simply committed unfinished (and messy) states of my code before (and pushed it) only for the purpose of pulling that in the other computer to continue the work. I am pretty sure this a bad ...
Greg Burghardt's user avatar
28 votes

In code review, should I ask to do a refactor outside of the scope in a pull request?

Just nitpicking, but usually I try to do the refactor before the change: Commit 1: Refactored class hierarchy in preparation for feature XY-123 Commit 2: Implemented feature XY-123 Another one I ...
Hermine's user avatar
  • 289
26 votes
Accepted

Why popular repositories use release version as a "Release title" in GitHub?

How to manage release with Git and GitHub ? The Git standard way of identifying a release is to create a version tag. This tag marks a specific version of your software in the change history of your ...
Christophe's user avatar
  • 78.7k
24 votes

Pull request merge process requiring rebase after every commit merged into master?

The core issue here is that your CI process takes hours. Everything else is standard good practice as far as many companies/developers are concerned. The reason to always expect a feature branch to be ...
Flater's user avatar
  • 53.1k
23 votes

How to ensure that developers see only the project modules they are working on?

Why you shouldn't do it from a team perspective The most important rules of project management regarding teams are: The project can be a success only through intense teamwork. Empowered teams that ...
Christophe's user avatar
  • 78.7k
16 votes
Accepted

How do we avoid development files in the release?

When we make a release, that release contains not only the actual release files but also contains all the meta and testing stuff. This happens because GitHub's way of creating releases is to simply ...
Maciej Stachowski's user avatar
16 votes

In code review, should I ask to do a refactor outside of the scope in a pull request?

For me, it depends on if the main change is difficult to follow without the refactor. If it is difficult to follow, I'll ask for the refactor to be done as part of the pull request, in the interest of ...
Karl Bielefeldt's user avatar
15 votes

Should I submit a pull request to correct minor typos in a Readme file?

Correct the typos and submit a pull request with the position of each correction in the summary field. That information is already visible when looking at the changes themselves, and any pull request ...
Flater's user avatar
  • 53.1k
15 votes
Accepted

Etiquette of mentioning issues/PRs from other projects (backlinks)

I don't understand the equivalence between linking issues (even across projects) and "me too" messages. They are not the same at all. We can continue to assume large project godzilla which ...
Thomas Owens's user avatar
  • 83.4k
14 votes

How can I start using Git in a project that is already underway?

I've done this a couple times. What I usually do (if using Github) is create a new empty repo on Github, clone it locally, copy my code into it, and push it all up.
GrandmasterB's user avatar
  • 39.4k
13 votes

Should I keep my GitHub forked repositories around forever?

Just to add to the answers provided - GitHub itself recommends deleting ("tidying") forked repositories after they've been merged. This can be done right in the pull request after merge - please see ...
Marius Balčytis's user avatar
13 votes

How do we avoid development files in the release?

I'd like to elaborate a bit on what @maciej-stachowski said: That's not entirely correct, as far as I can tell. In GitHub, a release is a tag pointing to a specific commit - and while GitHub ...
umläute's user avatar
  • 233
13 votes
Accepted

Should detected vulnerabilities in old commits be remedied?

I see two viable options here. First, release a patch version of the problematic version. For example, if the problematic version is version 3.3 and you're on version 5.1, you can release a 3.3.1 ...
Thomas Owens's user avatar
  • 83.4k
12 votes

Managing multiple people working on a project with GIT

I see only text answers here, so I thought I'd post a picture of a nice gitflow to start with. A picture describes more than a thousand words: This flow also works good with Continuous Deployment. ...
Jelle's user avatar
  • 2,044
12 votes

Declaring multiple licences in a GitHub project

I did eventually contact GitHub support directly with regard to my question and they said it was OK to quote them if I made clear their answers were only meant as suggestions, not recommendations. ...
Kay's user avatar
  • 956
11 votes
Accepted

Github - what is the best practice when working on open source project issues

Usually, for github, workflow is to have one fork (I even doubt you can fork the same repo more than once under the same account) but seperate branches per PR. Example: create fork, clone locally ...
stijn's user avatar
  • 4,138
11 votes
Accepted

Should I gitignore env files in my private repo?

Every time someones joins the team, I need to shared these .env files because it's not commited in the repo, which is something I don't like. There is a simple solution for this: gitignore .env files,...
Doc Brown's user avatar
  • 210k
10 votes
Accepted

GitHub - Should I unassign an issue once closed?

In general you don't want to unassign an issue if it's closed. There are two reasons why you don't want to do it: If an issue is reopened then you want the original people to be involved You want ...
Batavia's user avatar
  • 460
10 votes
Accepted

How do I start using Git for differing code bases from different servers?

Push the production stuff into the master branch of a new repo. Create a develop branch from that, and then merge the staging server into it. You may wind up with conflicts that need to be resolved. ...
mmathis's user avatar
  • 5,498

Only top scored, non community-wiki answers of a minimum length are eligible