Skip to main content
OverflowAI is here! AI power for your Stack Overflow for Teams knowledge community. Learn more
328 votes

How do I handle disagreement in a code review regarding an unlikely edge case?

I can give you an example of a corner case that could never occur that caused a disaster. When the Ariane 4 was being developed the values from the lateral accelerometers were scaled to fit into a 16-...
Steve Barnes's user avatar
  • 5,310
230 votes
Accepted

How do I handle disagreement in a code review regarding an unlikely edge case?

an obscure case that is extremely unlikely to happen--in fact I'm not sure it is even possible to occur Not having untested behaviors in code can be very important. If a piece of code is run e.g. 50 ...
9000's user avatar
  • 24.2k
87 votes

How do I handle disagreement in a code review regarding an unlikely edge case?

Since it wasn't handled before, it's out of scope for your effort. You or your colleague can ask your manager if it's worth the effort to cover this case.
kevin cline's user avatar
  • 33.7k
53 votes

How do I handle disagreement in a code review regarding an unlikely edge case?

With complex algorithms, it's very difficult to prove you have thought of every test case that will come up in the real world. When you intentionally leave a test case broken because it won't come up ...
Karl Bielefeldt's user avatar
51 votes

Am I right that switching programming languages will have little impact on the scalability of a CRUD API?

At a global level, you're wrong - language does matter, or at the very least you will spend more $$$ on compute if you write it in a less computationally efficient language. While I'm not at liberty ...
Philip Kendall's user avatar
42 votes
Accepted

Am I right that switching programming languages will have little impact on the scalability of a CRUD API?

There's a good video (warning, contains really a lot of swearing, but worth it) that will give you a good basis for arguing against this consultant... Solving Imaginary Scaling Issues (at Scale), by ...
user3067860's user avatar
38 votes

How do I handle disagreement in a code review regarding an unlikely edge case?

This is not a technical question but a business strategy decision. You notice the suggested fix is for a very obscure case which will almost never happen. Here it makes a big difference if you are ...
JacquesB's user avatar
  • 59.7k
23 votes

How do I handle disagreement in a code review regarding an unlikely edge case?

Code reviews are not purely about code correctness. In reality, that is quite far down the list of benefits, behind knowledge sharing and being a slow-but-steady process towards creating a team style/...
Neil Slater's user avatar
20 votes

Am I right that switching programming languages will have little impact on the scalability of a CRUD API?

You should remove this consultant from touching any of your system. A consultant suggesting a complete rewrite of an application in a different language are going to cause a lot of damage to the ...
Lie Ryan's user avatar
  • 12.4k
15 votes

How do I handle disagreement in a code review regarding an unlikely edge case?

I'd advise you to at least assert against the obscure case. That way, not only do future developers see that you actively decided against the case, but with a good failure handling, that should ...
WorldSEnder's user avatar
15 votes

Am I right that switching programming languages will have little impact on the scalability of a CRUD API?

With a simple CRUD api, your bottlenecks are probably the network and the database. So the code you use for mediating and translating between the two layers is probably not that performance-critical. ...
Philipp's user avatar
  • 23.3k
13 votes

How do I handle disagreement in a code review regarding an unlikely edge case?

Since you seem to be new there, there is only one thing you can do - check with the team leader (or project leader). 13 hours is a business decision; for some firms/teams, a lot; for some, nothing. It'...
Tom's user avatar
  • 139
10 votes

Do I need requirement analysis if there's no client?

The is no general answer to this question. Without external requirements, such as a project manager, other developers, a boss, a regulatory agency, and so on, there is no answer other than you need ...
Dan1701's user avatar
  • 3,108
7 votes

How do I handle disagreement in a code review regarding an unlikely edge case?

One thing I don't think I've seen addressed in kind, although it was kind of brought up in @SteveBarnes answer: What are the repercussions of a failure? In some fields a failure is an error on a web ...
WernerCD's user avatar
  • 812
6 votes

Two types of problems?

The binary nature of your observation stems from your own binary opinion that a certain implementation is either acceptable or not. What you're noticing is that you observe things to be the way you ...
Flater's user avatar
  • 51.7k
6 votes

How to deliver fast and avoid growth challenges with a codebase?

Goal Setting Regardless of if you are a half-man team or a 200 man team you need to be clear about what your goals are. Which mean yes there must be project management. Now you don't need to draft a ...
Kain0_0's user avatar
  • 16.2k
6 votes

How do I handle disagreement in a code review regarding an unlikely edge case?

The best way to handle disagreement is the same, regardless of if you're a junior developer or a senior developer, or even a CEO. Act like Columbo. If you've never watched any Columbo, it was a ...
Wayne Werner's user avatar
  • 2,370
6 votes

Am I right that switching programming languages will have little impact on the scalability of a CRUD API?

By that they seem to mean that a backend API written in .NET will handle the growing performance requirements much better than a backend API written in a scripting language like JavaScript, Ruby or ...
Telastyn's user avatar
  • 109k
5 votes

How do I handle disagreement in a code review regarding an unlikely edge case?

Maybe talk to the person who is responsible for prioritizing work? In startup could be CTO or product owner. He could help to find if this extra work is required and why. Also you could bring your ...
Konstantin Petrukhnov's user avatar
4 votes

Code review reasonable for on-spec project?

Do I have the wrong perspective here? To an extent, yes. It can be very difficult for a non-technical person to discern whether something they have is well-constructed or barely-holding-together junk....
user1118321's user avatar
  • 4,991
4 votes

Do I need requirement analysis if there's no client?

Do I need requirement analysis if there's no client? Requirements analysis includes things like identifying stakeholders, gathering requirements, ensuring they are good requirements and resolving ...
Thomas Owens's user avatar
  • 82.8k
4 votes
Accepted

Do I need requirement analysis if there's no client?

I think you're asking two somewhat different questions: (Smaller) Side Project For personal side projects, you obviously don't want to write a thousand pages of requirements specification - in fact, ...
doubleYou's user avatar
  • 2,807
4 votes
Accepted

Perfect product vs progressive releases

Even for the perfect product strategy you still need to iterate, you just iterate in secret. Taking Apple as an example of the perfect product strategy, and the first iphone as that product. They were ...
Joeri Sebrechts's user avatar
3 votes

How to deliver fast and avoid growth challenges with a codebase?

The challenge that you express is the following: Faster alone, further together - African proverb First of all, you shall not see testing as a luxury for bigger team. Writing some unit tests ...
Christophe's user avatar
  • 77.9k
3 votes

How do I handle disagreement in a code review regarding an unlikely edge case?

This question is not about about the virtues of defensive programming, the dangers of corner cases, or the catastrophic risks of bugs in physical products. In fact it's not even really about software ...
Jimmy Breck-McKye's user avatar
3 votes

How do I handle disagreement in a code review regarding an unlikely edge case?

Code review serves several purposes. One you are obviously aware of is, "Is this code fit for purpose?" In other words, is it functionally correct; is it adequately tested; are the non-obvious parts ...
Toby Speight's user avatar
3 votes

How do I handle disagreement in a code review regarding an unlikely edge case?

Code can ALWAYS be better. If you're in a code review and you don't see anything that might be better or a unit test that might catch a bug, it's not the code that's perfect, but the reviewer that ...
user261610's user avatar
3 votes

Am I right that switching programming languages will have little impact on the scalability of a CRUD API?

The scalability of a CRUD application is mainly linked to the completion of elementary transactions. Filling in a couple of variables and calling some functions is only a fraction of the time needed ...
Christophe's user avatar
  • 77.9k
2 votes

How do I handle disagreement in a code review regarding an unlikely edge case?

You should not escalate this to the management. In most companies the management guy will always chose to not write that extra test, to not spend time marginally improving the code quality, to not ...
Claudiu Creanga's user avatar

Only top scored, non community-wiki answers of a minimum length are eligible