Timeline for What SOLID principles am I breaking with this code?
Current License: CC BY-SA 4.0
6 events
when toggle format | what | by | license | comment | |
---|---|---|---|---|---|
Sep 12, 2019 at 11:13 | comment | added | Doc Brown | A better term than "species" would probably be "breed". | |
Sep 12, 2019 at 8:32 | comment | added | Kilian Foth | @Flater You're right, because of the "pet" domain I was thinking of domestic cats (F. catus). | |
Sep 12, 2019 at 8:32 | comment | added | Flater |
fur_color might be a naming issue more than a badly placed property. All animals have some color (whether one or multiple).
|
|
Sep 12, 2019 at 8:30 | comment | added | Flater | Cats aren't one species. E.g. there are 40 known species of wild cats. Even if you only focus on small-medium cats (which includes the domestic cat), that still means they only share a genus with varying species in the genus. Colloquially, cats are a family with many genuses and species. | |
Sep 12, 2019 at 7:43 | comment | added | NoName | Added the full code., sorry it was not allowing me to post it earlier. | |
Sep 12, 2019 at 7:28 | history | answered | Kilian Foth | CC BY-SA 4.0 |