Timeline for What to do if a core function does exactly what you need to do, but has a bug
Current License: CC BY-SA 4.0
7 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Jun 26, 2023 at 13:01 | comment | added | Taemyr | Yup, using the old function adds technical debt. | |
| Jun 23, 2023 at 12:53 | comment | added | OpenAI was the last straw |
@Taemyr And by writing "#" + oldfunction(...), OP would be adding more tech debt that will have to be addressed when the existing broken function is fixed. Depending on the practice of OP's team, OP may want to create another ticket that blocks the original, but the pros and cons of that decision would be better debated at PM.SE.
|
|
| Jun 22, 2023 at 23:54 | comment | added | Taemyr | Sure,unit tests can be wrong. However even when wrong they represent a past decision that the tested behavior is intended. And discarding that decision is beyond the scope of fixing a bug that occurs elsewhere in the solution. If the situation is as decribed in OP I would solve the bug by; Updating or writing a method documentation to make it clear that it does not include the hash symbol; Update the bugged method to use the old function - Ie. var color= "#"+oldfunction([args]); creating a ticket for changing the old function with a description to indicate flaws in current solution. | |
| Jun 22, 2023 at 13:06 | comment | added | OpenAI was the last straw | I am not disregarding the unit test. Unit tests can be wrong too. Many a developer has written unit tests based on the assumption that the existing behavior is correct. Is that useful? No, but people do it nonetheless. If we accepted unit tests as gospel, then we'd never refactor either. The solution is never to make a "new and improved" version next to the old version, nor to put a flag argument. | |
| Jun 22, 2023 at 11:14 | comment | added | Taemyr | You are disregarding the unit test. Someone looked at this function saw that it performed in a manner that OP considers "wrong", and decided that this is intended behaviour. | |
| S Jun 20, 2023 at 18:23 | review | First answers | |||
| Jun 21, 2023 at 2:16 | |||||
| S Jun 20, 2023 at 18:23 | history | answered | OpenAI was the last straw | CC BY-SA 4.0 |