Timeline for Code review from domain non expert
Current License: CC BY-SA 4.0
18 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Oct 6, 2023 at 15:19 | audit | First questions | |||
| Oct 6, 2023 at 15:20 | |||||
| Sep 21, 2023 at 12:29 | comment | added | Peter - Reinstate Monica | I'd be concerned if my reviewer did not ask such questions (but instead focused on indentation depth and copyright notices). | |
| Sep 20, 2023 at 9:35 | comment | added | Mast | A review by a non-domain-expert is always at least worth a shot if the alternative is no review at all. | |
| Sep 20, 2023 at 8:53 | answer | added | Ian Goldby | timeline score: 4 | |
| Sep 20, 2023 at 5:50 | vote | accept | user8469759 | ||
| Sep 19, 2023 at 19:33 | answer | added | candied_orange | timeline score: 7 | |
| Sep 19, 2023 at 17:04 | answer | added | bta | timeline score: 11 | |
| Sep 19, 2023 at 16:39 | comment | added | StuperUser | I value "obvious questions" or feedback as an important way to understand how and where to make a codebase more readable and accessible for future maintenance. Anyone, a non-domain expert or a junior developer, is a potential contributor. | |
| Sep 19, 2023 at 13:42 | comment | added | Jared Smith | One thing you can do (depending on the size of the team) is make sub-teams of people who have that specialty. For instance we had a subteam of "people who understand the CI/CD setup" and a ways of working agreement that all PRs that touched the CI/CD had to be reviewed by one of those people. If you do that though, make sure it's not some BS cool kids club: we gradually grew membership of that sub team from 3 people up to 6 as we did knowledge transfers. | |
| Sep 19, 2023 at 13:00 | comment | added | Pablo H | Perhaps you are more concerned about human factors than technical ones. | |
| Sep 19, 2023 at 12:02 | answer | added | Thomas Owens♦ | timeline score: 9 | |
| Sep 19, 2023 at 11:30 | comment | added | HectorLector | Regarding point 2: Usually you should have a separate process to define which 3rd party libraries are allowed in the code-bases, since there are many points to consider (license, maintenance, security etc.) | |
| Sep 19, 2023 at 11:17 | comment | added | Doc Brown | There are no dumb questions, only dumb answers. Hell, any question can be appropriate during a code review. If someone asks me "how does f internally work?" and I don't know it, I tell them exactly this, and expect them to accept this. | |
| Sep 19, 2023 at 10:43 | history | became hot network question | |||
| Sep 19, 2023 at 9:58 | answer | added | JonasH | timeline score: 14 | |
| Sep 19, 2023 at 6:51 | answer | added | gnasher729 | timeline score: 38 | |
| Sep 19, 2023 at 6:22 | answer | added | Rik D | timeline score: 73 | |
| Sep 19, 2023 at 2:41 | history | asked | user8469759 | CC BY-SA 4.0 |