Timeline for Code review from domain non expert
Current License: CC BY-SA 4.0
10 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Sep 22, 2023 at 8:32 | comment | added | David Z | @Laiv Likely someone else becomes the owner of that code. Or maybe it becomes unowned, if the company's system allows for that. | |
| Sep 20, 2023 at 5:50 | vote | accept | user8469759 | ||
| Sep 20, 2023 at 5:43 | comment | added | Alexander The 1st | @user8469759: Or perhaps as a TL:DR; - in situations like that, you might need to "Take [that part of] the code review offline" for a bit, to help bridge the gap - but it's in everyone's benefit that the questions are asked. | |
| Sep 20, 2023 at 5:25 | comment | added | Alexander The 1st | @user8469759: That's the situation where you might do a synchronous review (i.e. either in-person going over the code together, or over a phone/video call); you're still likely to have a large number of questions to field, but that balances out over the idea of "How does someone who is not a domain expert become a domain expert?". They're going to ask someone questions - and a domain expert is one of their better options of people they should ask. | |
| Sep 20, 2023 at 2:22 | comment | added | user8469759 | @Rik D I think a bit of my concern is what would happen in github, like endless conversations. It doesn't happen often, but it might happen. | |
| Sep 19, 2023 at 16:11 | comment | added | Laiv | Strong ownership... has to be interesting to know what happens when the strong owner leaves or get fired. | |
| Sep 19, 2023 at 12:41 | comment | added | Flater | @sleske: You're not wrong that it happens in reality, but if "bus factor" means anything to you it should be clear that "one person is responsible for each part of the code" is a massive liability and overall bad idea. It should be advocated against if this is the current status of the team. | |
| Sep 19, 2023 at 7:53 | comment | added | sleske | "Worth mentioning that code has no single ownership. " Worth mentioning that this is very team-specific. Some teams/organizations practice "strong code ownership", where one person is responsible for each part of the code, others practice "collective code ownership". Personally, I believe in collective ownership, but find out first how your team does it. | |
| Sep 19, 2023 at 6:40 | comment | added | Laiv | Worth mentioning that code has no single ownership. There's no "my code and your code". It's reasonable that any team member ask the code writer about the algorithm. It's in the benefit of all the team that everyone understands the code they work on. The key is on never approaching code reviews as we were a sort of Caesar (thump up/down) who decides the fate of every single line of code others write. | |
| Sep 19, 2023 at 6:22 | history | answered | Rik D | CC BY-SA 4.0 |