Skip to main content
3 of 6
added 229 characters in body
Zalomon
  • 1.2k
  • 3
  • 8
  • 18

How to deal with 'almost good' code

I got a question about team managing. Right now I'm dealing with a junior developer who's working remotely from a coding factory. The guy is open to criticism and willing to learn, but I got some doubts how much should I push some stuff.

Right now when something is straight and obvious a violation of good practices: like violation of SRP, God objects, non-meaningful names for methods or variables. I point out what to fix and tell him what to fix and try to explain why is wrong.

My question is: when do I stop? Right now if there are some minor violation of the coding style like variable names in the wrong language (previous team mixed Spanish and English and I'm trying to fix that), or some minor structure issues I'm letting go and fix it if I have any spare time or happen to need to modify the problematic class. I feel this is good for team morale so I'm not pushing back code constantly on what to a novice might seem like minor details, which can be quite frustrating, but I'm also worrying that being too 'soft' might prevent the guy from learning how to do some stuff.

So, long story short: should I push back code until I feel that anything that I'd change is personal preference and not justifiable on cleaniness and consistency?

EDIT: My question is how to balance the line between teaching the guy and not burning him out with constant criticism, for a junior it can be frustrating if you tell him to redo stuff that to his eyes is working.

Zalomon
  • 1.2k
  • 3
  • 8
  • 18