Skip to main content
Software Engineering

Return to Question

Post Closed as "Duplicate" by ozz, gnat, user53019, Kilian Foth, Dan Pichelman
added 6 characters in body; edited tags
Source Link
gnat
gnat
  • 20.9k
  • 29
  • 115
  • 295

I work on a team that does frequent code reviews. But it seems like more of a formality than anything. 

No one really points out problems in the code for fear of offending other developers. The few times I've tried to ask for changes were met with very defensive and reluctant attitudes. 

This is of course not good. Not only are we spending the time to code review, but we're getting literally zero value from it. Is this an issue that needs to be addressed by individual developers, or are there techniques for suggesting changes without stepping on other people's toes?

I work on a team that does frequent code reviews. But it seems like more of a formality than anything. No one really points out problems in the code for fear of offending other developers. The few times I've tried to ask for changes were met with very defensive and reluctant attitudes. This is of course not good. Not only are we spending the time to code review, but we're getting literally zero value from it. Is this an issue that needs to be addressed by individual developers, or are there techniques for suggesting changes without stepping on other people's toes?

I work on a team that does frequent code reviews. But it seems like more of a formality than anything. 

No one really points out problems in the code for fear of offending other developers. The few times I've tried to ask for changes were met with very defensive and reluctant attitudes. 

This is of course not good. Not only are we spending the time to code review, but we're getting literally zero value from it. Is this an issue that needs to be addressed by individual developers, or are there techniques for suggesting changes without stepping on other people's toes?

Post Migrated Here from workplace.stackexchange.com (revisions)
Source Link
ConditionRacer
ConditionRacer
  • 5.7k
  • 7
  • 40
  • 56

How to code review without offending other developers

I work on a team that does frequent code reviews. But it seems like more of a formality than anything. No one really points out problems in the code for fear of offending other developers. The few times I've tried to ask for changes were met with very defensive and reluctant attitudes. This is of course not good. Not only are we spending the time to code review, but we're getting literally zero value from it. Is this an issue that needs to be addressed by individual developers, or are there techniques for suggesting changes without stepping on other people's toes?