Timeline for Switch case for one condition
Current License: CC BY-SA 3.0
18 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Feb 14, 2022 at 14:40 | history | protected | gnat | ||
| Feb 14, 2022 at 12:55 | answer | added | Jonida Mersinllari | timeline score: 0 | |
| Mar 17, 2017 at 22:45 | answer | added | Bruno Brant | timeline score: 1 | |
| Mar 17, 2017 at 22:37 | answer | added | jleach | timeline score: 0 | |
| Mar 17, 2017 at 19:42 | answer | added | user3685427 | timeline score: 1 | |
| Mar 17, 2017 at 3:01 | history | edited | Dave Thomas | CC BY-SA 3.0 |
added 212 characters in body
|
| Mar 17, 2017 at 2:33 | comment | added | Dave Thomas | I ended up going with asking the intent of the programmer. It is always more polite in code review, to ask when things seem unclear. This ended up being the best choice for my way to give feedback. | |
| Mar 17, 2017 at 2:30 | vote | accept | Dave Thomas | ||
| Mar 16, 2017 at 21:52 | comment | added | Laiv | I agree with David, but I would ask first to the programmer, Why he/she thinks that the switch is the appropiated choice here. | |
| Mar 16, 2017 at 21:00 | answer | added | gnasher729 | timeline score: 4 | |
| Mar 16, 2017 at 20:30 | review | Close votes | |||
| Mar 21, 2017 at 3:05 | |||||
| Mar 16, 2017 at 20:18 | answer | added | user265760 | timeline score: 2 | |
| Mar 16, 2017 at 19:00 | comment | added | Andy |
This seems like an overkill. I would change it to an if.
|
|
| Mar 16, 2017 at 18:55 | history | edited | Dave Thomas | CC BY-SA 3.0 |
added 214 characters in body
|
| Mar 16, 2017 at 18:52 | comment | added | Dave Thomas | The switch is being used in a function written to purely decide whether or not to track something to Google Analytics. If the case is true the analytic event is tracked. | |
| Mar 16, 2017 at 18:51 | comment | added | Jules | How is the switch being used? There are cases (no pun intended) where the use of a switch is idiomatic in Android development even when only one case is present, eg checking the identifiers passed back to methods that handle events like dialog results. | |
| Mar 16, 2017 at 18:49 | review | First posts | |||
| Mar 16, 2017 at 20:13 | |||||
| Mar 16, 2017 at 18:45 | history | asked | Dave Thomas | CC BY-SA 3.0 |