Function that returns non parameter functions

Question

I found a function in c# like this:

  private Dictionary<string, Func<string>> ObtenerExtraCfgCampo(MsgDefCamp camp)
    {
        var extra = new Dictionary<string, Func<string>>();
        extra.Add("Oddity", () => camp.Order % 2 == 0 ? "Even" : "Odd");
        extra.Add("Odd", () => camp.Order % 2 == 0 ? "Odd" : string.Empty);
        extra.Add("Even", () => camp.Order % 2 != 0 ? "Even" : string.Empty);
        extra.Add("MsgPath", () => campo.MsgPath);
        return extra;

    }

Is there any utility on this? wouldn't it be better like this

private Dictionary<string, string> ObtenerExtraCfgCampo(MsgDefCamp camp)
{
    var extra = new Dictionary<string, string>();
    extra.Add("Oddity",  camp.Order % 2 == 0 ? "Even" : "Odd");
    extra.Add("Odd",  camp.Order % 2 == 0 ? "Odd" : string.Empty);
    extra.Add("Even",  camp.Order % 2 != 0 ? "Even" : string.Empty);
    extra.Add("MsgPath",  campo.MsgPath);
    return extra;

}

I undestand that changing camp would change the behavior of the functions. But isn't it too riski and difficult to reason about? I wonder if I'm missing the point of this

Answer 1

Ignoring the slight differences in type, interacting with the result of the first gives you a view onto the current state of camp, but the second gives a view onto some previous state of camp (I.E. when ObtenerExtraCfgCampo was called, probably billions of nanoseconds ago).

They do different things, so are not interchangeable. It's not any more risky than any other reference to mutable state.

I've just gone through most of an app changing a bunch of Dictionary<Whatever, string>s to Dictionary<Whatever, Func<string>>s so that we can change language at runtime

Answer 2

To see what the point of it is, try running the two versions of the method with mutating data, eg see here for an example of what happens.

The first version, using Func involves a closure over the MsgDefCamp instance. In other words, when the dictionary is interrogated it gets the current value, so in my example, it reports "Even" even though the value was off when the method was called.

The second version evaluates the contents of the MsgDefCamp instance when the method is called and stores those results in the dictionary. So even though the Order changes, the dictionary's value doesn't change and "Odd" is reported.

It can be difficult to reason if you aren't familiar with such code. It is an incredibly useful language feature though, so it's worth becoming familiar with it.