@Getter, @Setter vs @Data in lombok? [closed]

Question

So I was sending code for review and approvals for some changes I made recently. that includes a class as below:

import lombok.Getter;
import lombok.Setter;

@Getter
@Setter
public class UnKnownClientException extends CustomException {

public UnKnownClientException (String message, Throwable throwable) {
        super(message, throwable);
    }
}

@Setter
@Getter
public abstract class CustomException extends ContextedRuntimeException {

    private ApiException apiException;

    public CustomException (String message, Throwable throwable) {
        super(message, throwable);
    }

}

so there was a debate with my colleague as to use @Data vs @Getter, @Setter.

I was reasoning that as we are not using any other @Data shortcuts except, @Getter, @Setter, I added @Getter, @Setter but my colleague argues that it is safe to use @Data as a good practice. But I think as we have a custom constructor even with @Data we have to add that code manually. So not sure which side is correct. Looking for more insights..

Answer 1

@Data will turn your class into a full fledged DTO. Rather then simply letting you make your private members public it also implements toString, equals, and hash. Since you're not building a polymorphic encapsulated behavior object anyway you might as well add all the @Bells and @Whistles.

Yes it sticks you with a constructor you don't need, and thanks to those setters, lets anyone fiddle with it's data at any time but hey, you only live once. Some people insist on only adding what you really need. But they're no fun.

That might read as sarcasm but seriously it sounds like this codebase already doesn't care about ISP. Pick your fights wisely.