350 votes
Accepted

I changed one method signature and now have over 25,000 errors. What now?

25000 errors basically means "don't touch that". Change it back. Create a new class that has the desired interface and slowly move the consumers of the class to the new one. Depending on ...
Stephen's user avatar
  • 8,810
203 votes
Accepted

Should we design our code from the beginning to enable unit testing?

Reluctance to modify code for the sake of testing shows that a developer hasn't understood the role of tests, and by implication, their own role in the organization. The software business revolves ...
Kilian Foth's user avatar
165 votes
Accepted

How do I ensure that interface implementations are implemented in the manner I expected?

Instead of returning an int, return a value object that has the validation hard-coded. This is a case of primitive obsession and its fix. // should be class, not struct as struct can be created ...
Euphoric's user avatar
  • 37k
130 votes

What is meant by the phrase “Software can replace hardware”?

I am surprised nobody mentioned yet one of the most glaring examples: software-defined radio. If you took a present-day smartphone back in time some 50 years and showed it to a competent engineer ...
Viktor Toth's user avatar
  • 1,000
89 votes
Accepted

Better to have 2 methods with clear meaning, or just 1 dual use method?

You seem to suggest that the complexity of an interface is measured by the number of elements it has (methods, in this case). Many would argue that having to remember that the charge method can be ...
MichelHenrich's user avatar
80 votes

I changed one method signature and now have over 25,000 errors. What now?

Divide and conquer with refactorings Often, breaking up the change that you need to do into smaller steps can help because you can then perform most of the smaller steps in a way that doesn't break ...
theDmi's user avatar
  • 898
80 votes

Should I still follow "programming to an interface not implementation" even if I think using concrete class members is the simpler solution?

Programming to an interface means that you should focus on what the code does, not how it is actually implemented. See Telastyn's answer to Understanding “programming to an interface”. Interface ...
pschill's user avatar
  • 1,807
79 votes
Accepted

If I implement an Interface, is it called an Inheritance?

UPDATE: I've revised this answer. A number of good points were raised in the comments that deserved calling out. If my class implements an interface then can I say that I'm following inheritance? ...
Eric Lippert's user avatar
  • 45.9k
75 votes

Should we design our code from the beginning to enable unit testing?

It's not as simple as you might think. Let's break it down. Writing unit tests is definitely a good thing. BUT! Any change to your code can introduce a bug. So changing the code without a good ...
Ewan's user avatar
  • 72.4k
59 votes
Accepted

Implementing an interface when you don't need one of the properties

This is a classical example of how people decide to violate the Liskov Subtitution Principle. I strongly discourage it but would encourage possibly a different solution: Perhaps the class you're ...
Jimmy Hoffa's user avatar
51 votes

Is it ok to inherit a class without adding anything to the child, to respect the Open Closed principle?

No. Emphatic no. Unless I misunderstood you, the question is to subclass for a different behavior, but actually not have the behavior itself. Instead an outside actor checks the exact type and does ...
Robert Bräutigam's user avatar
49 votes

Should I still follow "programming to an interface not implementation" even if I think using concrete class members is the simpler solution?

"Programming to an interface" does not require the language keyword interface. It means you care about what promises the type provides about it's behaviour. You don't care how java.lang....
Caleth's user avatar
  • 10.7k
45 votes

Is it Good Practice to Only Expose Interfaces

As is the nature of using interfaces, this decouples my users from being concerned with how I variously decide to refactor the implementations. Let's take a step back and make sure we understand what ...
JimmyJames's user avatar
  • 25.9k
42 votes

What is meant by the phrase “Software can replace hardware”?

Consider this circuit: It is a Flip Flop, aka a Bistable Multivibrator. It can be replaced with this code: static bool toggle; if (toggle == true) { lblTop.BackColor = Color.Black; ...
Robert Harvey's user avatar
39 votes
Accepted

Implementation of pure abstract classes and interfaces

In C# and Java implementations, the objects typically have a single pointer to its class. This is possible because they are single-inheritance languages. The class structure then contains the vtable ...
amon's user avatar
  • 133k
39 votes
Accepted

Pass object twice to same method or consolidate with combined interface?

No, this is perfectly fine. It merely means that the API is over-engineered with regards to your current application. But that doesn't prove that there will never a use case in which the data source ...
Kilian Foth's user avatar
39 votes

In C#, is there a way to enforce behavior coupling in interface methods or is the fact that I am trying to do that a design smell?

What you are looking for is a well-known approach called Design by Contract. It was supported directly in the framework in version 4.0. DISCLOSURE: Be careful when adding code contracts to a new ...
Doc Brown's user avatar
  • 203k
38 votes
Accepted

What does the author mean by casting the interface reference to any implementation?

Abstracting your class into an interface is something you should consider if and only if you intend on writing other implementations of said interface or the strong possibility of doing so in the ...
Neil's user avatar
  • 22.7k
37 votes

In a fluent interface with "with", is cloning expected?

Looking at this code I’d have no idea. Semantically you did say it’s another pizza. But since this is of type Pizza and not a PizzaBuilder that gives you a pizza object only after you call the build ...
candied_orange's user avatar
36 votes

I changed one method signature and now have over 25,000 errors. What now?

Clarify your task with your boss to help him to understand the problem and your needs as a professional software developer. If you are part of a team, look for the lead developer and ask him for ...
mmehl's user avatar
  • 469
34 votes
Accepted

In C#, is there a way to enforce behavior coupling in interface methods or is the fact that I am trying to do that a design smell?

Well, first of all, let's tweak your interface a bit. public interface IComponent { void Enable(); void Disable(); bool IsEnabled { get; } } Now then. What could potentially go wrong ...
Robert Harvey's user avatar
33 votes
Accepted

Is this bad OOP design for a simulation involving interfaces?

In general you want to have interfaces for common characteristics of your clasess. I semi-agree with @Robert Harvey in the comments, who said that usually interfaces represent more abstract features ...
Paul92's user avatar
  • 2,571
32 votes

Generics vs common interface?

Let's first talk about pure parametric polymorphism and get into bounded polymorphism later. Parametric Polymorphism What does parametric polymorphism mean? Well, it means that a type, or rather ...
Jörg W Mittag's user avatar
32 votes
Accepted

Does it make sense to define an interface if I already have an abstract class?

Yes, because C# doesn't allow multiple inheritance except with interfaces. So if I have a class which is both a TypeNameMapper and SomethingelseMapper I can do: class MultiFunctionalClass : ...
Ewan's user avatar
  • 72.4k
32 votes

In C#, is there a way to enforce behavior coupling in interface methods or is the fact that I am trying to do that a design smell?

You're asking too much of C# Interfaces. C# Interfaces are contracts. They say what pack of methods a given class implements, and they guarantee that those methods will be there if someone calls them....
T. Sar's user avatar
  • 2,044
30 votes

What does the author mean by casting the interface reference to any implementation?

The accepted answer is correct and very useful, but I would like to briefly address specifically the line of code you asked about: ISomeClass myClass = new SomeClass(); Broadly speaking, this isn't ...
Kamil Drakari's user avatar
29 votes

Is this bad OOP design for a simulation involving interfaces?

Looks like you're creating a bunch of single method interfaces. This is fine on the face of it but keep in mind that interfaces are not owned by the class/es that implement them. They are owned by ...
candied_orange's user avatar
29 votes

I changed one method signature and now have over 25,000 errors. What now?

Don't touch it. Don't commit anything. Instead, sit down on your chair and shout "Heeeeelp!!!!!" as loud as you can. Well, not exactly like that, but ask any of your senior colleagues for advice. ...
gnasher729's user avatar
  • 43.5k
28 votes

Better to have 2 methods with clear meaning, or just 1 dual use method?

IMO, replacing getBalance() with charge(0) across your application isn't a simplification. Yes it is fewer lines, but it obfuscates the meaning of the charge() method, which could potentially cause ...
Matt Dalzell's user avatar

Only top scored, non community-wiki answers of a minimum length are eligible